Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: raoxu <raoxu@uniontech.com>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: restore MFG widget enumeration after core split
Date: Tue, 01 Sep 2026 12:38:32 +0200	[thread overview]
Message-ID: <874ig9dzo7.wl-tiwai@suse.de> (raw)
In-Reply-To: <44809B8FF80DCCA2+20260901034024.2407783-1-raoxu@uniontech.com>

On Tue, 01 Sep 2026 05:40:24 +0200,
raoxu wrote:
> 
> From: Xu Rao <raoxu@uniontech.com>
> 
> Before commit 7639a06c23c7 ("ALSA: hda - Move a part of hda_codec stuff
> into hdac_device"), widget enumeration selected the function group with
> 
> 	codec->afg ? codec->afg : codec->mfg
> 
> and read subordinate nodes from that group.
> 
> The core split moved this logic into snd_hdac_refresh_widgets(), but
> hard-coded codec->afg there. For an MFG-only codec, codec->afg is zero,
> so the Root Node is queried and codec->start_nid/num_nodes are populated
> from the function-group range instead of the MFG's subordinate nodes.
> 
> Restore the pre-split AFG-or-MFG selection.
> 
> Fixes: 7639a06c23c7 ("ALSA: hda - Move a part of hda_codec stuff into hdac_device")
> Signed-off-by: Xu Rao <raoxu@uniontech.com>

Thanks, applied now.

(Though, I've never seen an actual hardware with MFG, so it's likely
 no issue in practice :)


Takashi

      reply	other threads:[~2026-09-01 10:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  3:40 [PATCH] ALSA: hda: restore MFG widget enumeration after core split raoxu
2026-09-01 10:38 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ig9dzo7.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=raoxu@uniontech.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox