Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Michael Diesen <michael.diesen@posteo.de>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for HP Elite Dragonfly Folio G3 speakers
Date: Thu, 09 Jul 2026 11:18:02 +0200	[thread overview]
Message-ID: <874ii84j3p.wl-tiwai@suse.de> (raw)
In-Reply-To: <6b2b71bb318263aeb4f3ff67754d9978@posteo.de>

On Wed, 08 Jul 2026 22:04:31 +0200,
Michael Diesen wrote:
> 
> The HP Elite Dragonfly Folio G3 (PCI SSID 103c:8a05) has 4 CS35L41
> amplifiers on SPI, identical to the non-Folio Dragonfly G3 (103c:8981).
> Without this quirk the amps are never registered and speakers stay
> silent.
> 
> I've been carrying this as a local out-of-tree patch and would like
> to get it merged. Note there is a related, recently merged quirk for
> a neighboring SSID on what appears to be a sibling board variant:
> 
>   0a10faad5ca5 ("ALSA: hda/realtek: add quirk for HP Dragonfly Folio
>   G3 2-in-1", 103c:8a06), which uses the SPI4 + GPIO LED fixup
>   variant rather than plain SPI4.
> 
> My hardware (103c:8a05, "HP Elite Dragonfly Folio G3", non-2-in-1
> SKU) works correctly with the plain ALC245_FIXUP_CS35L41_SPI_4
> fixup and does not need the GPIO LED handling. Happy to re-test
> against SPI_4_HP_GPIO_LED if you think that's actually the more
> correct fixup for this board too ― let me know.
> 
> Signed-off-by: Michael Diesen <michael.diesen@posteo.de>
> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6817,6 +6817,7 @@
>       SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)",
> ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>       SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100",
> ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
>       SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9",
> ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> +     SND_PCI_QUIRK(0x103c, 0x8a05, "HP Elite Dragonfly Folio G3",
> ALC245_FIXUP_CS35L41_SPI_4),
>       SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx",
> ALC287_FIXUP_HP_GPIO_LED),
>       SND_PCI_QUIRK(0x103c, 0x8a1f, "HP Laptop 14s-dr5xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>       SND_PCI_QUIRK(0x103c, 0x8a20, "HP Laptop 15s-fq5xxx",
> ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),

The patch can't be applied cleanly via git-am, unfortunately, likely
because your mailer broke the space and lines.

Please fix your mailer setup and resubmit.
At best, try to send to yourself and test whether you can apply it via
git-am before the resubmission.


thanks,

Takashi

      reply	other threads:[~2026-07-09  9:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 20:04 [PATCH] ALSA: hda/realtek: Add quirk for HP Elite Dragonfly Folio G3 speakers Michael Diesen
2026-07-09  9:18 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ii84j3p.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=michael.diesen@posteo.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox