From: Takashi Iwai <tiwai@suse.de>
To: Haein Lee <lhi0729@kaist.ac.kr>
Cc: Takashi Iwai <tiwai@suse.de>,
perex@perex.cz, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org
Subject: Re: [PATCH v3] ALSA: usb-audio: Fix NULL pointer dereference in snd_usb_mixer_controls_badd
Date: Tue, 11 Nov 2025 18:34:16 +0100 [thread overview]
Message-ID: <874ir0jwx3.wl-tiwai@suse.de> (raw)
In-Reply-To: <vwhzmoba9j2f.vwhzmob9u9e2.g6@dooray.com>
On Tue, 11 Nov 2025 16:37:54 +0100,
Haein Lee wrote:
>
> In snd_usb_create_streams(), for UAC version 3 devices, the Interface
> Association Descriptor (IAD) is retrieved via usb_ifnum_to_if(). If this
> call fails, a fallback routine attempts to obtain the IAD from the next
> interface and sets a BADD profile. However, snd_usb_mixer_controls_badd()
> assumes that the IAD retrieved from usb_ifnum_to_if() is always valid,
> without performing a NULL check. This can lead to a NULL pointer
> dereference when usb_ifnum_to_if() fails to find the interface descriptor.
>
> This patch adds a NULL pointer check after calling usb_ifnum_to_if() in
> snd_usb_mixer_controls_badd() to prevent the dereference.
>
> This issue was discovered by syzkaller, which triggered the bug by sending
> a crafted USB device descriptor.
>
> Signed-off-by: Haein Lee <lhi0729@kaist.ac.kr>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-11-11 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 15:37 [PATCH v3] ALSA: usb-audio: Fix NULL pointer dereference in snd_usb_mixer_controls_badd Haein Lee
2025-11-11 17:34 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ir0jwx3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=lhi0729@kaist.ac.kr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox