From: Takashi Iwai <tiwai@suse.de>
To: Li Jun <lijun01@kylinos.cn>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org
Subject: Re: [PATCH] sound: isa: combine lines that defining variables and assigning values
Date: Mon, 09 Jun 2025 09:52:57 +0200 [thread overview]
Message-ID: <874iwp8i7a.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250606102538.95678-1-lijun01@kylinos.cn>
On Fri, 06 Jun 2025 12:25:38 +0200,
Li Jun wrote:
>
> Because the vars be assigning values immediately after
> defining, so combine them.
>
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
Thanks for the patch. But this doesn't improve the readability much,
nor fix any real bugs. As those are all legacy drivers, I'd rather
leave untouched.
Takashi
prev parent reply other threads:[~2025-06-09 7:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 10:25 [PATCH] sound: isa: combine lines that defining variables and assigning values Li Jun
2025-06-09 7:52 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874iwp8i7a.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=lijun01@kylinos.cn \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox