From: Takashi Iwai <tiwai@suse.de>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: virtualization@lists.linux.dev,
"Eugenio Pérez" <eperezma@redhat.com>,
"Matias Ezequiel Vara Larsen" <mvaralar@redhat.com>,
linux-sound@vger.kernel.org, "Jason Wang" <jasowang@redhat.com>,
linux-kernel@vger.kernel.org,
"Anton Yakovlev" <anton.yakovlev@opensynergy.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] virtio_snd.h: clarify that `controls` depends on VIRTIO_SND_F_CTLS
Date: Fri, 14 Feb 2025 12:58:34 +0100 [thread overview]
Message-ID: <874j0w3fh1.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250213161825.139952-1-sgarzare@redhat.com>
On Thu, 13 Feb 2025 17:18:25 +0100,
Stefano Garzarella wrote:
>
> As defined in the specification, the `controls` field in the configuration
> space is only valid/present if VIRTIO_SND_F_CTLS is negotiated.
>
> From https://docs.oasis-open.org/virtio/virtio/v1.3/virtio-v1.3.html:
>
> 5.14.4 Device Configuration Layout
> ...
> controls
> (driver-read-only) indicates a total number of all available control
> elements if VIRTIO_SND_F_CTLS has been negotiated.
>
> Let's use the same style used in virtio_blk.h to clarify this and to avoid
> confusion as happened in QEMU (see link).
>
> Link: https://gitlab.com/qemu-project/qemu/-/issues/2805
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-02-14 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 16:18 [PATCH] virtio_snd.h: clarify that `controls` depends on VIRTIO_SND_F_CTLS Stefano Garzarella
2025-02-14 8:28 ` Eugenio Perez Martin
2025-02-14 11:58 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j0w3fh1.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=anton.yakovlev@opensynergy.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mvaralar@redhat.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox