From: Takashi Iwai <tiwai@suse.de>
To: "\"Uwe Kleine-König (The Capable Hub)\"" <u.kleine-koenig@baylibre.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 13/17] ALSA: hda/core: Add include defining struct hda_device_id
Date: Wed, 01 Jul 2026 13:51:02 +0200 [thread overview]
Message-ID: <875x2zudw9.wl-tiwai@suse.de> (raw)
In-Reply-To: <1da60e376d9ef64b79d898c54fa58fef53d8168e.1782490566.git.u.kleine-koenig@baylibre.com>
On Fri, 26 Jun 2026 20:00:32 +0200,
Uwe Kleine-König (The Capable Hub) wrote:
>
> Traditionally all *_device_id were defined in a single header
> <linux/mod_devicetable.h>. This was split now with the objective that
> only the relevant bits are included. So including <linux/pci.h> won't be
> enough to get a definition of (the unrelated to pci) struct
> hda_device_id.
>
> Add an explicit include for the header defining struct hda_device_id to
> keep working when <linux/pci.h> stops providing this defintion.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
> ---
> include/sound/hdaudio.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
> index f11bfc6b9f42..e268ff9e9aa0 100644
> --- a/include/sound/hdaudio.h
> +++ b/include/sound/hdaudio.h
> @@ -11,6 +11,7 @@
> #include <linux/io.h>
> #include <linux/io-64-nonatomic-lo-hi.h>
> #include <linux/iopoll.h>
> +#include <linux/mod_device_id/hda.h>
> #include <linux/pci.h>
> #include <linux/pm_runtime.h>
> #include <linux/timecounter.h>
> --
> 2.47.3
>
next prev parent reply other threads:[~2026-07-01 11:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 18:00 [PATCH v2 00/17] mod_devicetable.h: Split into per subsystem headers Uwe Kleine-König (The Capable Hub)
2026-06-26 18:00 ` [PATCH v2 03/17] ASoC: rockchip: rockchip_sai: #include <linux/platform_device.h> explicitly Uwe Kleine-König (The Capable Hub)
2026-06-29 11:17 ` Mark Brown
2026-06-29 13:57 ` Uwe Kleine-König (The Capable Hub)
2026-06-26 18:00 ` [PATCH v2 13/17] ALSA: hda/core: Add include defining struct hda_device_id Uwe Kleine-König (The Capable Hub)
2026-07-01 11:51 ` Takashi Iwai [this message]
2026-06-27 16:07 ` [PATCH v2 00/17] mod_devicetable.h: Split into per subsystem headers Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x2zudw9.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=torvalds@linux-foundation.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox