From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: aoa: onyx: Update IEC958 sample-rate status for PCM playback
Date: Mon, 06 Apr 2026 10:41:36 +0200 [thread overview]
Message-ID: <875x64mqf3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260403-onyx-spdif-pcm-rate-v1-1-dcfaf931cf83@gmail.com>
On Fri, 03 Apr 2026 05:47:13 +0200,
Cássio Gabriel wrote:
>
> onyx_prepare() accepts 32/44.1/48 kHz PCM playback, but it leaves the
> Onyx IEC958 sample-rate status bits at the driver's initial 44.1 kHz
> setting in DIG_INFO3. As a result, 32 kHz and 48 kHz PCM streams
> advertise a stale IEC958 sample rate unless userspace rewrites IEC958
> Playback Default first.
>
> Update only the consumer sample-frequency bits in DIG_INFO3 from the PCM
> runtime during prepare, resolving the long-standing FIXME in the PCM
> playback path while leaving the other user-controlled IEC958 status bits
> unchanged.
>
> Mark IEC958 Playback Default as volatile as well, since prepare() now
> changes the exposed register contents outside the control put callback.
>
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Applied now to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-04-06 8:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 3:47 [PATCH] ALSA: aoa: onyx: Update IEC958 sample-rate status for PCM playback Cássio Gabriel
2026-04-06 8:41 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x64mqf3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox