public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ALSA: hda/realtek: add quirk for HP Laptop 15-fc0xxx
@ 2026-03-30  7:53 Zhang Heng
  2026-03-30  7:53 ` [PATCH 2/2] ALSA: hda/realtek: Add quirk for ASUS ROG Strix SCAR 15 Zhang Heng
  2026-03-30 11:47 ` [PATCH 1/2] ALSA: hda/realtek: add quirk for HP Laptop 15-fc0xxx Takashi Iwai
  0 siblings, 2 replies; 4+ messages in thread
From: Zhang Heng @ 2026-03-30  7:53 UTC (permalink / raw)
  To: tiwai, perex; +Cc: linux-sound, linux-kernel, Zhang Heng

For the HP Laptop 15-fc0xxx with ALC236, the built-in mic 0x12 was
not set up, making it unusable; after adding it, it now works properly.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=221233
Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
 sound/hda/codecs/realtek/alc269.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 6787e54fcfe6..0fd980596408 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -4123,6 +4123,7 @@ enum {
 	ALC245_FIXUP_BASS_HP_DAC,
 	ALC245_FIXUP_ACER_MICMUTE_LED,
 	ALC245_FIXUP_CS35L41_I2C_2_MUTE_LED,
+	ALC236_FIXUP_HP_INV_DMIC,
 };
 
 /* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -6658,6 +6659,13 @@ static const struct hda_fixup alc269_fixups[] = {
 		.v.func = alc245_fixup_hp_mute_led_coefbit,
 		.chained = true,
 		.chain_id = ALC287_FIXUP_CS35L41_I2C_2,
+	},
+	[ALC236_FIXUP_HP_INV_DMIC] = {
+		.type = HDA_FIXUP_PINS,
+		.v.pins = (const struct hda_pintbl[]) {
+			{ 0x12, 0x90a60160 }, /* use as internal mic */
+			{ }
+		},
 	}
 };
 
@@ -7152,6 +7160,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8da1, "HP 16 Clipper OmniBook X", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8da7, "HP 14 Enstrom OmniBook X", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8da8, "HP 16 Piston OmniBook X", ALC287_FIXUP_CS35L41_I2C_2),
+	SND_PCI_QUIRK(0x103c, 0x8dc9, "HP Laptop 15-fc0xxx", ALC236_FIXUP_HP_INV_DMIC),
 	SND_PCI_QUIRK(0x103c, 0x8dd4, "HP EliteStudio 8 AIO", ALC274_FIXUP_HP_AIO_BIND_DACS),
 	SND_PCI_QUIRK(0x103c, 0x8dd7, "HP Laptop 15-fd0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
 	SND_PCI_QUIRK(0x103c, 0x8de8, "HP Gemtree", ALC245_FIXUP_TAS2781_SPI_2),
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ALSA: hda/realtek: Add quirk for ASUS ROG Strix SCAR 15
  2026-03-30  7:53 [PATCH 1/2] ALSA: hda/realtek: add quirk for HP Laptop 15-fc0xxx Zhang Heng
@ 2026-03-30  7:53 ` Zhang Heng
  2026-03-30 11:47   ` Takashi Iwai
  2026-03-30 11:47 ` [PATCH 1/2] ALSA: hda/realtek: add quirk for HP Laptop 15-fc0xxx Takashi Iwai
  1 sibling, 1 reply; 4+ messages in thread
From: Zhang Heng @ 2026-03-30  7:53 UTC (permalink / raw)
  To: tiwai, perex; +Cc: linux-sound, linux-kernel, Zhang Heng, stable

ASUS ROG Strix SCAR 15, like the Strix G15, requires the
ALC285_FIXUP_ASUS_G533Z_PINS quirk to work properly.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=221247
Cc: <stable@vger.kernel.org>
Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 0fd980596408..0ed02e6d172a 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7277,6 +7277,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1043, 0x1533, "ASUS GV302XA/XJ/XQ/XU/XV/XI", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301VV/VQ/VU/VJ/VA/VC/VE/VVC/VQC/VUC/VJC/VEC/VCC", ALC285_FIXUP_ASUS_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1043, 0x1584, "ASUS UM3406GA ", ALC287_FIXUP_CS35L41_I2C_2),
+	SND_PCI_QUIRK(0x1043, 0x1602, "ASUS ROG Strix SCAR 15", ALC285_FIXUP_ASUS_G533Z_PINS),
 	SND_PCI_QUIRK(0x1043, 0x1652, "ASUS ROG Zephyrus Do 15 SE", ALC289_FIXUP_ASUS_ZEPHYRUS_DUAL_SPK),
 	SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
 	SND_PCI_QUIRK(0x1043, 0x1663, "ASUS GU603ZI/ZJ/ZQ/ZU/ZV", ALC285_FIXUP_ASUS_HEADSET_MIC),
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] ALSA: hda/realtek: add quirk for HP Laptop 15-fc0xxx
  2026-03-30  7:53 [PATCH 1/2] ALSA: hda/realtek: add quirk for HP Laptop 15-fc0xxx Zhang Heng
  2026-03-30  7:53 ` [PATCH 2/2] ALSA: hda/realtek: Add quirk for ASUS ROG Strix SCAR 15 Zhang Heng
@ 2026-03-30 11:47 ` Takashi Iwai
  1 sibling, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2026-03-30 11:47 UTC (permalink / raw)
  To: Zhang Heng; +Cc: tiwai, perex, linux-sound, linux-kernel

On Mon, 30 Mar 2026 09:53:33 +0200,
Zhang Heng wrote:
> 
> For the HP Laptop 15-fc0xxx with ALC236, the built-in mic 0x12 was
> not set up, making it unusable; after adding it, it now works properly.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=221233
> Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
> ---
>  sound/hda/codecs/realtek/alc269.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 6787e54fcfe6..0fd980596408 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -4123,6 +4123,7 @@ enum {
>  	ALC245_FIXUP_BASS_HP_DAC,
>  	ALC245_FIXUP_ACER_MICMUTE_LED,
>  	ALC245_FIXUP_CS35L41_I2C_2_MUTE_LED,
> +	ALC236_FIXUP_HP_INV_DMIC,

Any reason for "_INV_"?  Your implementation doesn't look related with
the existing inverted dmic workaround.


thanks,

Takashi

>  };
>  
>  /* A special fixup for Lenovo C940 and Yoga Duet 7;
> @@ -6658,6 +6659,13 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.v.func = alc245_fixup_hp_mute_led_coefbit,
>  		.chained = true,
>  		.chain_id = ALC287_FIXUP_CS35L41_I2C_2,
> +	},
> +	[ALC236_FIXUP_HP_INV_DMIC] = {
> +		.type = HDA_FIXUP_PINS,
> +		.v.pins = (const struct hda_pintbl[]) {
> +			{ 0x12, 0x90a60160 }, /* use as internal mic */
> +			{ }
> +		},
>  	}
>  };
>  
> @@ -7152,6 +7160,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x8da1, "HP 16 Clipper OmniBook X", ALC287_FIXUP_CS35L41_I2C_2),
>  	SND_PCI_QUIRK(0x103c, 0x8da7, "HP 14 Enstrom OmniBook X", ALC287_FIXUP_CS35L41_I2C_2),
>  	SND_PCI_QUIRK(0x103c, 0x8da8, "HP 16 Piston OmniBook X", ALC287_FIXUP_CS35L41_I2C_2),
> +	SND_PCI_QUIRK(0x103c, 0x8dc9, "HP Laptop 15-fc0xxx", ALC236_FIXUP_HP_INV_DMIC),
>  	SND_PCI_QUIRK(0x103c, 0x8dd4, "HP EliteStudio 8 AIO", ALC274_FIXUP_HP_AIO_BIND_DACS),
>  	SND_PCI_QUIRK(0x103c, 0x8dd7, "HP Laptop 15-fd0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>  	SND_PCI_QUIRK(0x103c, 0x8de8, "HP Gemtree", ALC245_FIXUP_TAS2781_SPI_2),
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] ALSA: hda/realtek: Add quirk for ASUS ROG Strix SCAR 15
  2026-03-30  7:53 ` [PATCH 2/2] ALSA: hda/realtek: Add quirk for ASUS ROG Strix SCAR 15 Zhang Heng
@ 2026-03-30 11:47   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2026-03-30 11:47 UTC (permalink / raw)
  To: Zhang Heng; +Cc: tiwai, perex, linux-sound, linux-kernel, stable

On Mon, 30 Mar 2026 09:53:34 +0200,
Zhang Heng wrote:
> 
> ASUS ROG Strix SCAR 15, like the Strix G15, requires the
> ALC285_FIXUP_ASUS_G533Z_PINS quirk to work properly.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=221247
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>

Applied this one for now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-03-30 11:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-30  7:53 [PATCH 1/2] ALSA: hda/realtek: add quirk for HP Laptop 15-fc0xxx Zhang Heng
2026-03-30  7:53 ` [PATCH 2/2] ALSA: hda/realtek: Add quirk for ASUS ROG Strix SCAR 15 Zhang Heng
2026-03-30 11:47   ` Takashi Iwai
2026-03-30 11:47 ` [PATCH 1/2] ALSA: hda/realtek: add quirk for HP Laptop 15-fc0xxx Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox