Re: [PATCH 1/2] ASoC: soc-core: add soc_rebind_card()

[Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>]

Hi Rojewski

Thank you for your review

> > +	soc_rebind_card();
> 
> The naming is off.  Clearly, we're not dealing with a card - many cards 
> could be bound here.
>
> As previous patches related to the subject removed the rebind_card() 
> function, I'm not sure we want it back.  Perhaps a readable macro instead?
> 
> #define for_each_unbound_card(card, c)
> 	list_for_each_entry_safe(card, c, &unbind_card_list, list)

Biggest concern here is that snd_soc_add_component() will goes to
soc-component.c, and it can't use "unbind_card_list" which will goto
soc-card.c as local variable (because of capsuling).

So, using #define is not enough. We would like to makes it as
"card function", and call it from soc-component.c.

How about "soc_try_bind_card_all()" or something ?

Note is that I would like to rename card function as "[snd_]soc_card_xxx()"
when it goes to soc-card.c
ex)
	soc_bind_card()		-> soc_card_bind()
	soc_unbind_card()	-> soc_card_unbind()
	soc_try_bind_card_all()	-> soc_card_try_bind_all()

Thank you for your help !!

Best regards
---
Kuninori Morimoto