Re: [PATCH 00/89] ASoC: Convert to modern PM macros

[Takashi Iwai <tiwai@suse.de>]

aOn Fri, 14 Mar 2025 08:02:50 +0100,
Geraldo Nascimento wrote:
> 
> On Thu, Mar 13, 2025 at 06:40:05PM +0100, Takashi Iwai wrote:
> > This is a series of small and trivial patches to convert to the newer
> > PM macros, e.g. from SET_RUNTIME_PM_OPS() to RUNTIME_PM_OPS().
> > 
> > The conversions are systematic, and we could reduce messy
> > __maybe_unused and ifdefs with those changes.
> > 
> > Merely code refactoring, and shouldn't change the actual driver
> > behavior.
> > 
> > 
> > Takashi
> 
> Hi Takashi,
> 
> some of the patches for RUNTIME_PM_OPS() have typos in them stating
> RUNTIE_PM_OPS() (note the missing M) in the commit message.
> At a quick glance all of the commit titles are correctly
> stated as is, it's just some of the commit messages that
> got wrongly copypasted.
> 
> Since this will go through your own sound.git tree, presumably,
> and the change is strictly cosmetic do you think you could
> correct it later on when merging this? It's quite a bunch of
> individual patches you have to "s/ RUNTIE_PM_OPS()/ RUNTIME_PM_OPS()"
> by the way.
> 
> Any decision is up to you and since the commit titles are
> right anyway it shouldn't be a major problem for e.g.
> naive grepping of the git log. But it definitely looks funny.

I can resubmit with typo fixes if needed.  Otherwise, as ASoC patches
are merged via Mark's tree (then through mine), Mark would have to
correct at applying, instead.


thanks,

Takashi