Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Athaariq Ardhiansyah <foss@athaariq.my.id>
Cc: linux-sound@vger.kernel.org, kailang@realtek.com.tw,
	pshou@realtek.com.tw, tiwai@suse.de, jwoithe@just42.net
Subject: Re: [PATCH 1/1] ALSA: hda/realtek: fix ALC285 issues on HP Envy x360 laptops
Date: Fri, 08 Mar 2024 09:16:17 +0100	[thread overview]
Message-ID: <877cidxhny.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240308005912.456727-1-foss@athaariq.my.id>

On Fri, 08 Mar 2024 01:59:12 +0100,
Athaariq Ardhiansyah wrote:
> 
> @@ -9862,6 +9923,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x103c, 0x880d, "HP EliteBook 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8811, "HP Spectre x360 15-eb1xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1),
>  	SND_PCI_QUIRK(0x103c, 0x8812, "HP Spectre x360 15-eb1xxx", ALC285_FIXUP_HP_SPECTRE_X360_EB1),
> +	SND_PCI_QUIRK(0x103c, 0x85de, "HP Envy x360 13-ar0xxx", ALC285_FIXUP_HP_ENVY_X360),
>  	SND_PCI_QUIRK(0x103c, 0x881d, "HP 250 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>  	SND_PCI_QUIRK(0x103c, 0x8846, "HP EliteBook 850 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),
>  	SND_PCI_QUIRK(0x103c, 0x8847, "HP EliteBook x360 830 G8 Notebook PC", ALC285_FIXUP_HP_GPIO_LED),

The table is sorted in PCI SSID order.  Could you put the entry at the
right position?


thanks,

Takashi

  reply	other threads:[~2024-03-08 11:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08  0:59 [PATCH 1/1] ALSA: hda/realtek: fix ALC285 issues on HP Envy x360 laptops Athaariq Ardhiansyah
2024-03-08  8:16 ` Takashi Iwai [this message]
2024-03-09 10:46   ` [PATCH v2] " Athaariq Ardhiansyah
2024-03-10 13:58   ` [PATCH v3] " Athaariq Ardhiansyah
2024-03-11  8:14     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cidxhny.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=foss@athaariq.my.id \
    --cc=jwoithe@just42.net \
    --cc=kailang@realtek.com.tw \
    --cc=linux-sound@vger.kernel.org \
    --cc=pshou@realtek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox