From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9FC62C68A for ; Mon, 15 Jan 2024 11:43:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Jq50A1Iy"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zvdKjrSZ"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Jq50A1Iy"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zvdKjrSZ" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DE46C21F34; Mon, 15 Jan 2024 11:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705319005; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cKYUIs8LOhJvH5ElLyrjy4ttc0LpXOsCJQSUlNKrYsI=; b=Jq50A1IyTburzp77epdbT1D4zpGExaSKi3X58/npLmdLFvzkFYW4gugpYIL6koZ/hRIUTC 0B/J+Z3hPMrPDErg309R0A/RCQTUSneXwS/7DJN0NUiYiVglQ58zjSrnfPxKumk6Fyr40x EE6UR6Klfff+TOpmtbWH3/Rojfh7wg8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705319005; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cKYUIs8LOhJvH5ElLyrjy4ttc0LpXOsCJQSUlNKrYsI=; b=zvdKjrSZEnzWSWyJVkaUKVvFL3C4AqKsQI57+Wn/lIfWX7O61L6Nz27zZW7cdjN9bC7rLf jQPnusd0WobXwcDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705319005; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cKYUIs8LOhJvH5ElLyrjy4ttc0LpXOsCJQSUlNKrYsI=; b=Jq50A1IyTburzp77epdbT1D4zpGExaSKi3X58/npLmdLFvzkFYW4gugpYIL6koZ/hRIUTC 0B/J+Z3hPMrPDErg309R0A/RCQTUSneXwS/7DJN0NUiYiVglQ58zjSrnfPxKumk6Fyr40x EE6UR6Klfff+TOpmtbWH3/Rojfh7wg8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705319005; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cKYUIs8LOhJvH5ElLyrjy4ttc0LpXOsCJQSUlNKrYsI=; b=zvdKjrSZEnzWSWyJVkaUKVvFL3C4AqKsQI57+Wn/lIfWX7O61L6Nz27zZW7cdjN9bC7rLf jQPnusd0WobXwcDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A525113712; Mon, 15 Jan 2024 11:43:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id ViG5Jl0apWXiQAAAD6G6ig (envelope-from ); Mon, 15 Jan 2024 11:43:25 +0000 Date: Mon, 15 Jan 2024 12:43:25 +0100 Message-ID: <877ckayg82.wl-tiwai@suse.de> From: Takashi Iwai To: Heiner Kallweit Cc: Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org Subject: Re: [PATCH] ALSA: hda: generic: Remove obsolete call to ledtrig_audio_get In-Reply-To: <3dc9167d-fb33-43a6-baa6-dbef8b5da7b9@gmail.com> References: <3dc9167d-fb33-43a6-baa6-dbef8b5da7b9@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [0.64 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MID_CONTAINS_FROM(1.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.26)[73.59%] X-Spam-Level: X-Spam-Flag: NO X-Spam-Score: 0.64 On Sat, 13 Jan 2024 17:08:54 +0100, Heiner Kallweit wrote: > > Since 64f67b5240db ("leds: trigger: audio: Add an activate callback to > ensure the initial brightness is set") the audio triggers have an > activate callback which sets the LED brightness as soon as the > (default) trigger is bound to the LED device. So we can remove the > call to ledtrig_audio_get. > > Positive side effect: We have no code dependency to ledtrig-audio any > longer, therefore, if built as module, it's no longer loaded if not > needed. > > Signed-off-by: Heiner Kallweit Thanks, applied now. Takashi