public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Rocket Raccoon <rakketje1@gmail.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.com, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10
Date: Fri, 27 Mar 2026 10:52:41 +0100	[thread overview]
Message-ID: <878qbdsiom.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAL76xbU81CKcbAD436djDbJ8P+xsj0r24i7phFG1YcSVr2n2JQ@mail.gmail.com>

On Wed, 25 Mar 2026 13:26:54 +0100,
Rocket Raccoon wrote:
> 
> The Lenovo Yoga 7 2-in-1 14AKP10 (PCI subsystem ID 0x17aa:0x391c) uses
> an ALC287 HDA codec paired with a TAS2781 amplifier connected via I2C.
> Without this quirk the amplifier is not initialised and internal speaker
> output lacks amplification.
> 
> Signed-off-by: Lucas <rakketje1@gmail.com>

The Signed-off-by line must be a real name or a known identity as it's
a legal requirement.  (Also it's better aligned with From line.)

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index XXXXXXX..XXXXXXX 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -XXXXX,6 +XXXXX,7 @@ static const struct snd_pci_quirk alc287_fixup_tbl[] = {
>   SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo Yoga Pro 9 14IRP8",
> ALC287_FIXUP_TAS2781_I2C),
> + SND_PCI_QUIRK(0x17aa, 0x391c, "Lenovo Yoga 7 2-in-1 14AKP10",
> ALC287_FIXUP_TAS2781_I2C),
>   SND_PCI_QUIRK(0x17aa, 0x3819, "Lenovo 13s Gen2 ITL",
> ALC287_FIXUP_13S_GEN2_SPEAKERS),

... and the patch seems not applicable cleanly.  Please fix your
mailer setup, too.


thanks,

Takashi

  reply	other threads:[~2026-03-27  9:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 12:26 [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10 Rocket Raccoon
2026-03-27  9:52 ` Takashi Iwai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-10-18 14:20 J-Donald Tournier
2025-10-18 14:25 ` Takashi Iwai
2025-10-18 14:52   ` J-Donald Tournier
2025-10-18 16:37     ` Takashi Iwai
2025-10-18 14:00 J-Donald Tournier
2025-10-18 14:13 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qbdsiom.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=rakketje1@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox