* [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10
@ 2026-03-25 12:26 Rocket Raccoon
2026-03-27 9:52 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Rocket Raccoon @ 2026-03-25 12:26 UTC (permalink / raw)
To: alsa-devel; +Cc: tiwai, linux-sound
The Lenovo Yoga 7 2-in-1 14AKP10 (PCI subsystem ID 0x17aa:0x391c) uses
an ALC287 HDA codec paired with a TAS2781 amplifier connected via I2C.
Without this quirk the amplifier is not initialised and internal speaker
output lacks amplification.
Signed-off-by: Lucas <rakketje1@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index XXXXXXX..XXXXXXX 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -XXXXX,6 +XXXXX,7 @@ static const struct snd_pci_quirk alc287_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo Yoga Pro 9 14IRP8",
ALC287_FIXUP_TAS2781_I2C),
+ SND_PCI_QUIRK(0x17aa, 0x391c, "Lenovo Yoga 7 2-in-1 14AKP10",
ALC287_FIXUP_TAS2781_I2C),
SND_PCI_QUIRK(0x17aa, 0x3819, "Lenovo 13s Gen2 ITL",
ALC287_FIXUP_13S_GEN2_SPEAKERS),
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10
2026-03-25 12:26 [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10 Rocket Raccoon
@ 2026-03-27 9:52 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2026-03-27 9:52 UTC (permalink / raw)
To: Rocket Raccoon; +Cc: alsa-devel, tiwai, linux-sound
On Wed, 25 Mar 2026 13:26:54 +0100,
Rocket Raccoon wrote:
>
> The Lenovo Yoga 7 2-in-1 14AKP10 (PCI subsystem ID 0x17aa:0x391c) uses
> an ALC287 HDA codec paired with a TAS2781 amplifier connected via I2C.
> Without this quirk the amplifier is not initialised and internal speaker
> output lacks amplification.
>
> Signed-off-by: Lucas <rakketje1@gmail.com>
The Signed-off-by line must be a real name or a known identity as it's
a legal requirement. (Also it's better aligned with From line.)
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index XXXXXXX..XXXXXXX 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -XXXXX,6 +XXXXX,7 @@ static const struct snd_pci_quirk alc287_fixup_tbl[] = {
> SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo Yoga Pro 9 14IRP8",
> ALC287_FIXUP_TAS2781_I2C),
> + SND_PCI_QUIRK(0x17aa, 0x391c, "Lenovo Yoga 7 2-in-1 14AKP10",
> ALC287_FIXUP_TAS2781_I2C),
> SND_PCI_QUIRK(0x17aa, 0x3819, "Lenovo 13s Gen2 ITL",
> ALC287_FIXUP_13S_GEN2_SPEAKERS),
... and the patch seems not applicable cleanly. Please fix your
mailer setup, too.
thanks,
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10
@ 2025-10-18 14:20 J-Donald Tournier
2025-10-18 14:25 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: J-Donald Tournier @ 2025-10-18 14:20 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-sound
This laptop requires the same quirk as Lenovo Yoga9 14IAP7 for
fixing the bass speaker problems.
Use HDA_CODEC_QUIRK to match on the codec SSID to avoid conflict with
the Lenovo Legion Slim 7 16IRH8, which has the same PCI SSID.
Signed-off-by: J-Donald Tournier <jdournier@gmail.com>
---
sound/hda/codecs/realtek/alc269.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/hda/codecs/realtek/alc269.c
b/sound/hda/codecs/realtek/alc269.c
index 214eb9df6ef8..93fa4b888fef 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7078,6 +7078,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x38a9, "Thinkbook 16P",
ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
SND_PCI_QUIRK(0x17aa, 0x38ab, "Thinkbook 16P",
ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
SND_PCI_QUIRK(0x17aa, 0x38b4, "Legion Slim 7 16IRH8",
ALC287_FIXUP_CS35L41_I2C_2),
+ HDA_CODEC_QUIRK(0x17aa, 0x391c, "Lenovo Yoga 7 2-in-1
14AKP10", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
SND_PCI_QUIRK(0x17aa, 0x38b5, "Legion Slim 7 16IRH8",
ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x17aa, 0x38b6, "Legion Slim 7 16APH8",
ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x17aa, 0x38b7, "Legion Slim 7 16APH8",
ALC287_FIXUP_CS35L41_I2C_2),
--
2.51.1.dirty
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10
2025-10-18 14:20 J-Donald Tournier
@ 2025-10-18 14:25 ` Takashi Iwai
2025-10-18 14:52 ` J-Donald Tournier
0 siblings, 1 reply; 8+ messages in thread
From: Takashi Iwai @ 2025-10-18 14:25 UTC (permalink / raw)
To: J-Donald Tournier; +Cc: Takashi Iwai, linux-sound
On Sat, 18 Oct 2025 16:20:44 +0200,
J-Donald Tournier wrote:
>
> This laptop requires the same quirk as Lenovo Yoga9 14IAP7 for
> fixing the bass speaker problems.
>
> Use HDA_CODEC_QUIRK to match on the codec SSID to avoid conflict with
> the Lenovo Legion Slim 7 16IRH8, which has the same PCI SSID.
>
> Signed-off-by: J-Donald Tournier <jdournier@gmail.com>
Thanks. But, unfortunately, now I noticed that your mailer broke the
tabs and spaces, so the patch can't be applied cleanly.
Could you try to send via git-send-email? If it doesn't work, use an
attachment as a last resort.
Takashi
> ---
> sound/hda/codecs/realtek/alc269.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/hda/codecs/realtek/alc269.c
> b/sound/hda/codecs/realtek/alc269.c
> index 214eb9df6ef8..93fa4b888fef 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7078,6 +7078,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x17aa, 0x38a9, "Thinkbook 16P",
> ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
> SND_PCI_QUIRK(0x17aa, 0x38ab, "Thinkbook 16P",
> ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
> SND_PCI_QUIRK(0x17aa, 0x38b4, "Legion Slim 7 16IRH8",
> ALC287_FIXUP_CS35L41_I2C_2),
> + HDA_CODEC_QUIRK(0x17aa, 0x391c, "Lenovo Yoga 7 2-in-1
> 14AKP10", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
> SND_PCI_QUIRK(0x17aa, 0x38b5, "Legion Slim 7 16IRH8",
> ALC287_FIXUP_CS35L41_I2C_2),
> SND_PCI_QUIRK(0x17aa, 0x38b6, "Legion Slim 7 16APH8",
> ALC287_FIXUP_CS35L41_I2C_2),
> SND_PCI_QUIRK(0x17aa, 0x38b7, "Legion Slim 7 16APH8",
> ALC287_FIXUP_CS35L41_I2C_2),
> --
> 2.51.1.dirty
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10
2025-10-18 14:25 ` Takashi Iwai
@ 2025-10-18 14:52 ` J-Donald Tournier
2025-10-18 16:37 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: J-Donald Tournier @ 2025-10-18 14:52 UTC (permalink / raw)
To: tiwai, linux-sound; +Cc: J-Donald Tournier
This laptop requires the same quirk as Lenovo Yoga9 14IAP7 for
fixing the bass speaker problems.
Use HDA_CODEC_QUIRK to match on the codec SSID to avoid conflict with
the Lenovo Legion Slim 7 16IRH8, which has the same PCI SSID.
Signed-off-by: J-Donald Tournier <jdournier@gmail.com>
---
sound/hda/codecs/realtek/alc269.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 214eb9df6ef8..93fa4b888fef 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7078,6 +7078,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x38a9, "Thinkbook 16P", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
SND_PCI_QUIRK(0x17aa, 0x38ab, "Thinkbook 16P", ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
SND_PCI_QUIRK(0x17aa, 0x38b4, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2),
+ HDA_CODEC_QUIRK(0x17aa, 0x391c, "Lenovo Yoga 7 2-in-1 14AKP10", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
SND_PCI_QUIRK(0x17aa, 0x38b5, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x17aa, 0x38b6, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x17aa, 0x38b7, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2),
--
2.51.1.dirty
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10
2025-10-18 14:52 ` J-Donald Tournier
@ 2025-10-18 16:37 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2025-10-18 16:37 UTC (permalink / raw)
To: J-Donald Tournier; +Cc: tiwai, linux-sound, J-Donald Tournier
On Sat, 18 Oct 2025 16:52:26 +0200,
J-Donald Tournier wrote:
>
> This laptop requires the same quirk as Lenovo Yoga9 14IAP7 for
> fixing the bass speaker problems.
>
> Use HDA_CODEC_QUIRK to match on the codec SSID to avoid conflict with
> the Lenovo Legion Slim 7 16IRH8, which has the same PCI SSID.
>
> Signed-off-by: J-Donald Tournier <jdournier@gmail.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10
@ 2025-10-18 14:00 J-Donald Tournier
2025-10-18 14:13 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: J-Donald Tournier @ 2025-10-18 14:00 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-sound
This laptop requires the same quirk as Lenovo Yoga9 14IAP7 for
fixing the bass speaker problems.
Use HDA_CODEC_QUIRK to match on the codec SSID to avoid conflict with
the Lenovo Legion Slim 7 16IRH8, which has the same PCI SSID.
---
sound/hda/codecs/realtek/alc269.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/hda/codecs/realtek/alc269.c
b/sound/hda/codecs/realtek/alc269.c
index 214eb9df6ef8..93fa4b888fef 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7078,6 +7078,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x38a9, "Thinkbook 16P",
ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
SND_PCI_QUIRK(0x17aa, 0x38ab, "Thinkbook 16P",
ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD),
SND_PCI_QUIRK(0x17aa, 0x38b4, "Legion Slim 7 16IRH8",
ALC287_FIXUP_CS35L41_I2C_2),
+ HDA_CODEC_QUIRK(0x17aa, 0x391c, "Lenovo Yoga 7 2-in-1
14AKP10", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
SND_PCI_QUIRK(0x17aa, 0x38b5, "Legion Slim 7 16IRH8",
ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x17aa, 0x38b6, "Legion Slim 7 16APH8",
ALC287_FIXUP_CS35L41_I2C_2),
SND_PCI_QUIRK(0x17aa, 0x38b7, "Legion Slim 7 16APH8",
ALC287_FIXUP_CS35L41_I2C_2),
--
2.51.1.dirty
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10
2025-10-18 14:00 J-Donald Tournier
@ 2025-10-18 14:13 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2025-10-18 14:13 UTC (permalink / raw)
To: J-Donald Tournier; +Cc: Takashi Iwai, linux-sound
On Sat, 18 Oct 2025 16:00:38 +0200,
J-Donald Tournier wrote:
>
> This laptop requires the same quirk as Lenovo Yoga9 14IAP7 for
> fixing the bass speaker problems.
>
> Use HDA_CODEC_QUIRK to match on the codec SSID to avoid conflict with
> the Lenovo Legion Slim 7 16IRH8, which has the same PCI SSID.
Could you resubmit the patch with your Signed-off-by tag? It's a
legal requirement. The code change itself looks good.
thanks,
Takashi
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-03-27 9:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-25 12:26 [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga 7 2-in-1 14AKP10 Rocket Raccoon
2026-03-27 9:52 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2025-10-18 14:20 J-Donald Tournier
2025-10-18 14:25 ` Takashi Iwai
2025-10-18 14:52 ` J-Donald Tournier
2025-10-18 16:37 ` Takashi Iwai
2025-10-18 14:00 J-Donald Tournier
2025-10-18 14:13 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox