Re: [PATCH] ALSA: hda: Remove duplicate cmedia entries in codecs Makefile

[Takashi Iwai <tiwai@suse.de>]

On Sun, 26 Apr 2026 02:03:27 +0200,
Sasha Levin wrote:
> 
> kconfiglint reports:
> 
>   M004: 'snd-hda-codec-cmedia-y' assigned with ':=' but was already
>         assigned at line 5; previous value is overwritten
> 
> sound/hda/codecs/Makefile contains duplicate entries for the C-Media
> codec driver ― both the composite module definition and the obj-* build
> target appear twice:
> 
>   Line 5:  snd-hda-codec-cmedia-y :=  cmedia.o
>   Line 10: snd-hda-codec-cmedia-y :=  cmedia.o  (duplicate)
>   Line 24: obj-$(CONFIG_SND_HDA_CODEC_CMEDIA) += snd-hda-codec-cmedia.o
>   Line 29: obj-$(CONFIG_SND_HDA_CODEC_CMEDIA) += snd-hda-codec-cmedia.o  (duplicate)
> 
> This file was created by commit 6014e9021b28 ("ALSA: hda: Move codec
> drivers into sound/hda/codecs directory") which
> moved codec drivers from sound/pci/hda/ to sound/hda/codecs/. In that
> initial file, cmedia appeared once in each section.
> 
> Immediately after, commit aeeb85f26c3b ("ALSA: hda: Split Realtek
> HD-audio codec driver") reordered the entries and
> inserted cmedia at new positions near the top of each section, as part
> of splitting out the Realtek driver. However, the original cmedia entries
> were not removed during this reordering, creating duplicates of both
> lines. The second assignment harmlessly overwrites the first with the
> same value, and the second obj-* line causes the module to be listed
> twice ― neither causes a build failure, but both are dead code.
> 
> Remove the duplicate entries (second occurrence of each).
> 
> Assisted-by: Claude:claude-opus-4-6 kconfiglint
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Applied now.  Thanks.


Takashi