From: Takashi Iwai <tiwai@suse.de>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Cássio Gabriel" <cassiogabrielcontato@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: interwave: fix build warnings with CONFIG_PM=n
Date: Mon, 13 Apr 2026 09:31:51 +0200 [thread overview]
Message-ID: <87a4v7wc2g.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260413071217.3830320-1-arnd@kernel.org>
On Mon, 13 Apr 2026 09:12:11 +0200,
Arnd Bergmann wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Parts of the newly added power management code are identified
> as unused by gcc:
>
> sound/isa/gus/interwave.c:489:13: error: 'snd_interwave_restore_memory' defined but not used [-Werror=unused-function]
> 489 | static void snd_interwave_restore_memory(struct snd_gus_card *gus)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/isa/gus/interwave.c:483:13: error: 'snd_interwave_restore_regs' defined but not used [-Werror=unused-function]
> 483 | static void snd_interwave_restore_regs(struct snd_gus_card *gus)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from sound/isa/gus/interwave-stb.c:3:
> sound/isa/gus/interwave.c:489:13: error: 'snd_interwave_restore_memory' defined but not used [-Werror=unused-function]
> 489 | static void snd_interwave_restore_memory(struct snd_gus_card *gus)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/isa/gus/interwave.c:483:13: error: 'snd_interwave_restore_regs' defined but not used [-Werror=unused-function]
> 483 | static void snd_interwave_restore_regs(struct snd_gus_card *gus)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Add an #ifdef check around these to match the callers.
>
> Fixes: 6f800c3397b7 ("ALSA: interwave: add ISA and PnP suspend and resume callbacks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, this should have been already fixed on sound git tree by the
commit b7feba842c0d5f6c5b01592f80d164e974767501
ALSA: interwave: guard PM-only restore helpers with CONFIG_PM
Takashi
prev parent reply other threads:[~2026-04-13 7:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 7:12 [PATCH] ALSA: interwave: fix build warnings with CONFIG_PM=n Arnd Bergmann
2026-04-13 7:31 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4v7wc2g.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox