From: Takashi Iwai <tiwai@suse.de>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH v1] ALSA: aoa: Constify struct codec_connection
Date: Sat, 28 Feb 2026 09:33:31 +0100 [thread overview]
Message-ID: <87a4wt6zdw.wl-tiwai@suse.de> (raw)
In-Reply-To: <4009c337cc1a1a57795562279270c03687973b3b.1772138640.git.christophe.jaillet@wanadoo.fr>
On Thu, 26 Feb 2026 21:44:10 +0100,
Christophe JAILLET wrote:
>
> 'struct codec_connection' are not modified in this driver.
>
> Constifying these structures moves some data to a read-only section, so
> increases overall security.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
> text data bss dec hex filename
> 10034 3392 12 13438 347e sound/aoa/fabrics/layout.o
>
> After:
> =====
> text data bss dec hex filename
> 10370 3040 12 13422 346e sound/aoa/fabrics/layout.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> Compile tested only.
>
> The fabric_data field in struct aoa_codecis is only used in
> sound/aoa/fabrics/layout.c, so there should be no side effect for other
> files that include sound/aoa/aoa.h
Applied to for-next branch now. Thanks.
Takashi
prev parent reply other threads:[~2026-02-28 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 20:44 [PATCH v1] ALSA: aoa: Constify struct codec_connection Christophe JAILLET
2026-02-28 8:33 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4wt6zdw.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=johannes@sipsolutions.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox