From: Takashi Iwai <tiwai@suse.de>
To: wangdich9700@163.com
Cc: tiwai@suse.com, broonie@kernel.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, wangdicheng@kylinos.cn
Subject: Re: [PATCH 2/2] ALSA: hda/conexant: Add NULL check for dc_mode_path
Date: Wed, 29 Jul 2026 09:48:28 +0200 [thread overview]
Message-ID: <87bjbq5j8z.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260729070935.548050-2-wangdich9700@163.com>
On Wed, 29 Jul 2026 09:09:35 +0200,
wangdich9700@163.com wrote:
>
> From: wangdicheng <wangdicheng@kylinos.cn>
>
> snd_hda_add_new_path() returns NULL when no path exists between the
> given NIDs, but olpc_xo_update_mic_pins() passes dc_mode_path
> straight to snd_hda_activate_path() which dereferences it without
> checking. Add the missing NULL guards, same as the local path
> variable already has in the same function.
>
> Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
Applied to for-next branch now. Thanks.
Takashi
next prev parent reply other threads:[~2026-07-29 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 7:09 [PATCH 1/2] ALSA: hda/conexant: Fix EAPD pin array overflow wangdich9700
2026-07-29 7:09 ` [PATCH 2/2] ALSA: hda/conexant: Add NULL check for dc_mode_path wangdich9700
2026-07-29 7:48 ` Takashi Iwai [this message]
2026-07-29 7:33 ` [PATCH 1/2] ALSA: hda/conexant: Fix EAPD pin array overflow Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjbq5j8z.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=wangdich9700@163.com \
--cc=wangdicheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox