From: Takashi Iwai <tiwai@suse.de>
To: wangdich9700@163.com
Cc: tiwai@suse.de, david.laight.linux@gmail.com,
wangdicheng@kylinos.cn, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ALSA: sparc/dbri: Fix "possible condition with no effect" warning
Date: Sun, 19 Jul 2026 10:42:38 +0200 [thread overview]
Message-ID: <87bjc3s741.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260717091542.721877-3-wangdich9700@163.com>
On Fri, 17 Jul 2026 11:15:41 +0200,
wangdich9700@163.com wrote:
>
> From: wangdicheng <wangdicheng@kylinos.cn>
>
> Fix a compiler warning about a condition with no effect:
>
> sound/sparc/dbri.c:1843:1-3: WARNING: possible condition with no effect (if == else)
>
> When DBRI_DEBUG is not defined, dprintk expands to an empty do-while
> statement, making both branches of the if-else no-ops. Guard the entire
> debug block with #ifdef DBRI_DEBUG to eliminate the warning and keep
> the rval reference consistent with its declaration scope.
>
> Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
Applied to for-next branch. Thanks.
Takashi
next prev parent reply other threads:[~2026-07-19 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 9:15 [PATCH v2 0/3] ALSA: Fix compiler warnings in sound subsystem wangdich9700
2026-07-17 9:15 ` [PATCH v2 1/3] ASoC: mediatek: mt8189: Remove redundant else-if branch with identical body wangdich9700
2026-07-17 9:15 ` [PATCH v2 2/3] ALSA: sparc/dbri: Fix "possible condition with no effect" warning wangdich9700
2026-07-19 8:42 ` Takashi Iwai [this message]
2026-07-17 9:15 ` [PATCH v2 3/3] ASoC: fsl_easrc: Use div64_u64 for 64-by-64 division wangdich9700
2026-07-18 0:24 ` (subset) [PATCH v2 0/3] ALSA: Fix compiler warnings in sound subsystem Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjc3s741.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=wangdich9700@163.com \
--cc=wangdicheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox