From: Takashi Iwai <tiwai@suse.de>
To: Dylan Robinson <dylan_robinson@motu.com>
Cc: linux-sound@vger.kernel.org, tiwai@suse.com, perex@perex.cz
Subject: Re: [PATCH] ALSA: usb-audio: Fix max bytes-per-interval calculation
Date: Tue, 25 Nov 2025 07:59:23 +0100 [thread overview]
Message-ID: <87bjkqpph0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20251124210518.90054-1-dylan_robinson@motu.com>
On Mon, 24 Nov 2025 22:05:18 +0100,
Dylan Robinson wrote:
>
> The maxpacksize field in struct audioformat represents the maximum number
> of bytes per isochronous interval. The current implementation only
> special-cases high-speed endpoints and does not account for the different
> computations required for SuperSpeed, SuperSpeedPlus, or eUSB2. As a
> result, USB audio class devices operating at these speeds may fail to
> stream correctly. The issue was observed on a MOTU 16A (2025) interface,
> which requires more than 1024 bytes per interval at SuperSpeed.
>
> This patch replaces the existing logic with a helper that computes the
> correct maximum bytes-per-interval for all USB speeds, borrowing the logic
> used in drivers/usb/core/urb.c.
>
> Signed-off-by: Dylan Robinson <dylan_robinson@motu.com>
Applied to for-next branch now. Thanks!
Takashi
next prev parent reply other threads:[~2025-11-25 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 21:05 [PATCH] ALSA: usb-audio: Fix max bytes-per-interval calculation Dylan Robinson
2025-11-25 6:59 ` Takashi Iwai [this message]
2025-11-29 19:56 ` Michal Pecio
2025-11-30 10:53 ` Takashi Iwai
2025-11-30 12:00 ` Michal Pecio
2025-11-30 12:08 ` Takashi Iwai
2025-12-01 10:47 ` Michal Pecio
2025-12-01 23:10 ` Dylan Robinson
2025-12-02 7:08 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bjkqpph0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=dylan_robinson@motu.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox