Re: [PATCH] ALSA: kunit: fix build warning in test_card_set_id

[Takashi Iwai <tiwai@suse.de>]

On Mon, 07 Apr 2025 17:40:18 +0200,
Takashi Iwai wrote:
> 
> On Mon, 07 Apr 2025 11:21:36 +0200,
> xiaopeitux@foxmail.com wrote:
> > 
> > From: Pei Xiao <xiaopei01@kylinos.cn>
> > 
> > build W=1 warning:
> > sound/core/sound_kunit.c: In function 'test_card_set_id':
> >    include/linux/printk.h:455:44: warning: '%s' directive argument is null [-Wformat-overflow=]
> > 
> > Fix -Wformat-overflow warning when card->id could be NULL.
> > The kunit_info() call with "%s" format specifier may receive a NULL
> > pointer from card->id. Add a ternary conditional to safely handle
> > potential NULL values by substituting "(null)" when card->id is NULL.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202504050922.ZzbkiojG-lkp@intel.com/
> > Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
> 
> Thanks, applied now.  I added Fixes tag manually
> (Fixes: 3e39acf56ede ("ALSA: core: Add sound core KUnit test"))
> 
> But at the next time, please try to put the proper Fixes tag.

... and as 0day bot spotted out, this fix is bogus.
snd_card.id is an embedded array, and can be never NULL.

I drop the patch now.


Takashi