Re: [PATCH v2] ALSA: hda/ca0132: Add Sound BlasterX AE-5 external RGB LED strip support

[Takashi Iwai <tiwai@suse.de>]

On Sat, 03 Oct 2026 03:41:51 +0200,
dchristensen8 wrote:
> 
> Hi Takashi,
> 
> Thanks for the review! I moved the dma-mapping.h include into the main header block, added the s->opened check to ae5_strip_find_stream(), wrapped all the strip code in IS_ENABLED(CONFIG_SND_HDA_DSP_LOADER) with a no-op stub when it's disabled, and updated the put callbacks to return 1 when the values actually change.

This looks like a patch on top of the previous one?
Please submit a complete single patch.  Also, can you try to submit
without an attachment, at best, with git-am?  If it's difficult, it's
fine with an attachment as a fallback, though.

> One other thing: I was talking with the maintainer of openrgb and he suggested a patch to make zone0 led's work via the same mechanism (this card has onboard led's at zone0 and external led's at zone1). Should I add that to this patch or submit a separate patch after this one is completed?

Let's make a separate path.  The current one looks already enough, and
if any, we can change incrementally.


thanks,

Takashi