From: Takashi Iwai <tiwai@suse.de>
To: Baojun Xu <baojun.xu@ti.com>
Cc: <broonie@kernel.org>, <andriy.shevchenko@linux.intel.com>,
<alsa-devel@alsa-project.org>, <shenghao-ding@ti.com>,
<navada@ti.com>, <13916275206@139.com>, <v-hampiholi@ti.com>,
<v-po@ti.com>, <linux-sound@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: hda/tas2781: Fix calibration data parser issue
Date: Mon, 07 Jul 2025 11:29:51 +0200 [thread overview]
Message-ID: <87cyacnyb4.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250707090513.1462-1-baojun.xu@ti.com>
On Mon, 07 Jul 2025 11:05:13 +0200,
Baojun Xu wrote:
>
> We will copy calibration data from position behind to front.
> We has created a variable (tmp_val) point on top of calibration data
> buffer, and tmp_val[1] is max of node number in original calibration
> data structure, it will be overwritten after first data copy,
> so can't be used as max node number check in for loop.
> So we create a new variable to save max of node number (tmp_val[1]),
> used to check if max node number was reached in for loop.
> And a point need to be increased to point at calibration data in node.
> Data saved position also need to be increased one byte.
>
> Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib")
>
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>
>
> ---
> Change in v2:
> - Add more description about this fix.
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-07-07 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 9:05 [PATCH v2] ALSA: hda/tas2781: Fix calibration data parser issue Baojun Xu
2025-07-07 9:29 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyacnyb4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=shenghao-ding@ti.com \
--cc=v-hampiholi@ti.com \
--cc=v-po@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox