Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Moritz Baron <moritz.baron@stud.uni-hannover.de>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-kernel@i4.cs.fau.de,
	Felix Aljoscha Schnuell
	<felix.aljoscha.schnuell@stud.uni-hannover.de>
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14IRH8
Date: Tue, 09 Jun 2026 12:54:36 +0200	[thread overview]
Message-ID: <87ecig6l1v.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260608202055.206744-1-moritz.baron@stud.uni-hannover.de>

On Mon, 08 Jun 2026 22:20:54 +0200,
Moritz Baron wrote:
> 
> The Lenovo Yoga Pro 7 14IRH8 (ALC287 codec, subsystem ID 0x17aa:0x38b1)
> has bass speakers on pin 0x17 that are not routed through a DAC with
> volume control. This causes the bass speakers to play at full volume
> regardless of the volume slider position.
> 
> Apply ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN which corrects the DAC
> routing for pin 0x17, enabling proper volume control. This is the same
> fix used for other Yoga Pro 7 models with identical audio topology
> (14APH8, 14AHP9, 14ASP10, 14IAH10).
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217949
> 
> Co-developed-by: Felix Aljoscha Schnuell <felix.aljoscha.schnuell@stud.uni-hannover.de>
> Signed-off-by: Felix Aljoscha Schnuell <felix.aljoscha.schnuell@stud.uni-hannover.de>
> Signed-off-by: Moritz Baron <moritz.baron@stud.uni-hannover.de>
> ---
>  sound/hda/codecs/realtek/alc269.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index dcbc669842e0..9b1e65f6d161 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -7711,6 +7711,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
>  	 * use codec SSID to distinguish them
>  	 */
>  	HDA_CODEC_QUIRK(0x17aa, 0x38cf, "Lenovo Yoga Pro 7 14IMH9", ALC287_FIXUP_YOGA9_14IMH9_BASS_SPK_PIN),
> +	HDA_CODEC_QUIRK(0x17aa, 0x38b1, "Lenovo Yoga Pro 7 14IRH8", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),

Your machine seems to have a different PCI SSID (17aa:3852) from the
entry above, so it's not appropriate to put here.

Instead, put one before the entry of 17aa:3852 below, with a brief
comment that it's for avoiding the confliction with the PCI SSID
17aa:3852.

>  	SND_PCI_QUIRK(0x17aa, 0x3847, "Legion 7 16ACHG6", ALC287_FIXUP_LEGION_16ACHG6),
>  	SND_PCI_QUIRK(0x17aa, 0x384a, "Lenovo Yoga 7 15ITL5", ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),
>  	SND_PCI_QUIRK(0x17aa, 0x3852, "Lenovo Yoga 7 14ITL5", ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),

... the conflicting entry is found here above.


thanks,

Takashi

  reply	other threads:[~2026-06-09 10:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08 20:20 [PATCH] ALSA: hda/realtek: Add quirk for Lenovo Yoga Pro 7 14IRH8 Moritz Baron
2026-06-09 10:54 ` Takashi Iwai [this message]
2026-06-09 14:16   ` [PATCH v2] " Moritz Baron
2026-06-10  7:24     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecig6l1v.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=felix.aljoscha.schnuell@stud.uni-hannover.de \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=moritz.baron@stud.uni-hannover.de \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox