From: Takashi Iwai <tiwai@suse.de>
To: Kyle Zeng <kylebot@openai.com>
Cc: linux-sound@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: seq: dummy: fix UMP event stack overread
Date: Fri, 05 Jun 2026 10:09:43 +0200 [thread overview]
Message-ID: <87ecilv260.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260605080204.32045-1-kylebot@openai.com>
On Fri, 05 Jun 2026 10:02:04 +0200,
Kyle Zeng wrote:
>
> The dummy sequencer port forwards events by copying an incoming
> struct snd_seq_event into a stack temporary, rewriting source and
> destination, and dispatching the temporary to subscribers. That legacy
> event storage is smaller than struct snd_seq_ump_event.
>
> When a UMP event reaches the dummy client, the copy leaves the UMP flag
> set but only provides legacy-sized stack storage. The subscriber
> delivery path then uses snd_seq_event_packet_size() and copies a
> UMP-sized packet from that stack object, reading past the end of the
> temporary.
>
> Use the existing union __snd_seq_event storage and copy the packet size
> reported for the incoming event before rewriting the common routing
> fields. This preserves the full UMP packet for UMP events while keeping
> legacy event handling unchanged.
>
> Fixes: 32cb23a0f911 ("ALSA: seq: dummy: Allow UMP conversion")
> Signed-off-by: Kyle Zeng <kylebot@openai.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-06-05 8:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 8:02 [PATCH] ALSA: seq: dummy: fix UMP event stack overread Kyle Zeng
2026-06-05 8:09 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecilv260.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=kylebot@openai.com \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox