From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: broonie@kernel.org, tiwai@suse.com, perex@perex.cz,
amade@asmblr.net, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: core: Move all users to deferrable card binding
Date: Mon, 11 May 2026 01:34:08 +0000 [thread overview]
Message-ID: <87ecjin300.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20260430140752.766130-1-cezary.rojewski@intel.com>
Hi Cezary
Thank you for the patch.
And sorry for my late response, it was long holiday in Japan.
> Commit a3375522bb5e2 ("ASoC: core: Complete support for card rebinding")
> completed the feature and at the same time divided ASoC users into two
> groups:
>
> 1) cards that fail to enumerate the moment one of the components is
> not available
> 2) cards that succeed to enumerate even if some of their components
> become available late
>
> Given the component-based nature of ASoC, approach 2) is preferred and
> can be used by all ASoC users. By dropping 1) the card binding code can
> also be simplified.
>
> Flatten code that is currently conditional based on ->devres_dev and
> convert snd_soc_rebind_card() to call_soc_bind_card(). The latter is a
> selector between managed and unmanaged card-binding behaviour to keep
> non-devm users happy.
>
> With rebinding being the default, devm_snd_soc_register_card() takes
> form of its deferrable friend - all the devm job is already done by
> devm_snd_soc_bind_card().
>
> Suggested-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
> ---
It looks more simple, thank you !
2 questions.
Q1. this means, devm_ register user can use auto rebind, normal user can't,
but is this correct ?
Q2. If so, list_xxx() can be done in devm_snd_soc_bind_card(), instead of
normal snd_soc_bind_card(), but what do you think ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
prev parent reply other threads:[~2026-05-11 1:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 14:07 [PATCH] ASoC: core: Move all users to deferrable card binding Cezary Rojewski
2026-05-11 1:06 ` Mark Brown
2026-05-11 1:34 ` Kuninori Morimoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecjin300.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=amade@asmblr.net \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox