[PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx

[PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx

[Sharan Kumar M]

This patch adds the HP OMEN 16 Laptop xd000xx to enable mute led.
it uses ALC245_FIXUP_HP_MUTE_LED_COEFBIT with a slight modification setting mute_led_coef.off to 0(it was set to 4 i guess 
in that function) which i referred to your previous patch disscusion https://bugzilla.kernel.org/show_bug.cgi?id=214735 .
i am not sure whether i can modify the current working function so i added another version calling
ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT. and both works for me.

Tested on 6.13.4-arch1-1 to 6.14.0-arch1-1


Signed-off-by: Sharan Kumar M <sharweshraajan@gmail.com>


---
 sound/pci/hda/patch_realtek.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b4fe681ec3cb..98abec3833a0 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4743,6 +4743,22 @@ static void alc245_fixup_hp_mute_led_coefbit(struct hda_codec *codec,
 	}
 }
 
+static void alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec,
+					  const struct hda_fixup *fix,
+					  int action)
+{
+	struct alc_spec *spec = codec->spec;
+
+	if (action == HDA_FIXUP_ACT_PRE_PROBE) {
+		spec->mute_led_polarity = 0;
+		spec->mute_led_coef.idx = 0x0b;
+		spec->mute_led_coef.mask = 1 << 3;
+		spec->mute_led_coef.on = 1 << 3;
+		spec->mute_led_coef.off = 0;
+		snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);
+	}
+}
+
 /* turn on/off mic-mute LED per capture hook by coef bit */
 static int coef_micmute_led_set(struct led_classdev *led_cdev,
 				enum led_brightness brightness)
@@ -7911,6 +7927,7 @@ enum {
 	ALC245_FIXUP_TAS2781_SPI_2,
 	ALC287_FIXUP_YOGA7_14ARB7_I2C,
 	ALC245_FIXUP_HP_MUTE_LED_COEFBIT,
+	ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT,
 	ALC245_FIXUP_HP_X360_MUTE_LEDS,
 	ALC287_FIXUP_THINKPAD_I2S_SPK,
 	ALC287_FIXUP_MG_RTKC_CSAMP_CS35L41_I2C_THINKPAD,
@@ -10164,6 +10181,10 @@ static const struct hda_fixup alc269_fixups[] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc245_fixup_hp_mute_led_coefbit,
 	},
+	[ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc245_fixup_hp_mute_led_v1_coefbit,
+	},
 	[ALC245_FIXUP_HP_X360_MUTE_LEDS] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc245_fixup_hp_mute_led_coefbit,
@@ -10658,6 +10679,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8b97, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x8bb3, "HP Slim OMEN", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8bb4, "HP Slim OMEN", ALC287_FIXUP_CS35L41_I2C_2),
+	SND_PCI_QUIRK(0x103c, 0x8bcd, "HP Omen 16-xd0xxx", ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT),
 	SND_PCI_QUIRK(0x103c, 0x8bdd, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8bde, "HP Envy 17", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8bdf, "HP Envy 15", ALC287_FIXUP_CS35L41_I2C_2),
-- 
2.49.0

Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx

[Takashi Iwai]

On Sat, 29 Mar 2025 16:41:06 +0100,
Sharan Kumar M wrote:
> 
> This patch adds the HP OMEN 16 Laptop xd000xx to enable mute led.
> it uses ALC245_FIXUP_HP_MUTE_LED_COEFBIT with a slight modification setting mute_led_coef.off to 0(it was set to 4 i guess 
> in that function) which i referred to your previous patch disscusion https://bugzilla.kernel.org/show_bug.cgi?id=214735 .
> i am not sure whether i can modify the current working function so i added another version calling
> ALC245_FIXUP_HP_MUTE_LED_V1_COEFBIT. and both works for me.
> 
> Tested on 6.13.4-arch1-1 to 6.14.0-arch1-1
> 
> 
> Signed-off-by: Sharan Kumar M <sharweshraajan@gmail.com>

Thanks, applied now.


Takashi

[PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx

[Sharan Kumar Muthu Saravanan]

this patch makes the mute led brighter since the previous patch i
submitted was dim

Tested on 6.15.5-arch1-1

Signed-off-by: Sharan Kumar M <sharweshraajan@gmail.com>

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 060db37eab83..062d439e753d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4753,7 +4753,7 @@ static void
alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec,
        if (action == HDA_FIXUP_ACT_PRE_PROBE) {
                spec->mute_led_polarity = 0;
                spec->mute_led_coef.idx = 0x0b;
-               spec->mute_led_coef.mask = 1 << 3;
+               spec->mute_led_coef.mask = 3 << 2;
                spec->mute_led_coef.on = 1 << 3;
                spec->mute_led_coef.off = 0;
                snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);
---

Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx

[Takashi Iwai]

On Fri, 11 Jul 2025 08:23:09 +0200,
Sharan Kumar Muthu Saravanan wrote:
> 
> this patch makes the mute led brighter since the previous patch i
> submitted was dim
> 
> Tested on 6.15.5-arch1-1
> 
> Signed-off-by: Sharan Kumar M <sharweshraajan@gmail.com>
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 060db37eab83..062d439e753d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4753,7 +4753,7 @@ static void
> alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec,
>         if (action == HDA_FIXUP_ACT_PRE_PROBE) {
>                 spec->mute_led_polarity = 0;
>                 spec->mute_led_coef.idx = 0x0b;
> -               spec->mute_led_coef.mask = 1 << 3;
> +               spec->mute_led_coef.mask = 3 << 2;
>                 spec->mute_led_coef.on = 1 << 3;
>                 spec->mute_led_coef.off = 0;
>                 snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);
> ---

The patch isn't applicable cleanly at all.
Please try to submit in a proper format.  At best, test by yourself
whether you can apply the patch locally before the next submission.

Also, the patch description is too ambiguous.  Please describe more
exactly what was wrong and what you changed.

Last but not least, please add Fixes tag pointing to your previous fix
mentioned in the patch.


thanks,

Takashi

[PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx

[Sharan Kumar Muthu Saravanan]

this patch is to fix my previous Commit e518230 i have fixed mute led
but for by This patch corrects the coefficient mask value introduced
in commit e518230, which was intended to enable the mute LED
functionality. During testing, multiple values were evaluated, and an
incorrect value was mistakenly included in the final commit. This
update fixes that error by applying the correct mask value for proper
mute LED behavior.

Tested on 6.15.5-arch1-1

Signed-off-by: M SHARAN KUMAR <sharweshraajan@gmail.com>

---
 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 060db37eab83..062d439e753d 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4753,7 +4753,7 @@ static void
alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec,
  if (action == HDA_FIXUP_ACT_PRE_PROBE) {
  spec->mute_led_polarity = 0;
  spec->mute_led_coef.idx = 0x0b;
- spec->mute_led_coef.mask = 1 << 3;
+ spec->mute_led_coef.mask = 3 << 2;
  spec->mute_led_coef.on = 1 << 3;
  spec->mute_led_coef.off = 0;
  snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);
-- 
2.50.1

Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx

[Takashi Iwai]

On Thu, 17 Jul 2025 05:02:19 +0200,
Sharan Kumar Muthu Saravanan wrote:
> 
> this patch is to fix my previous Commit e518230 i have fixed mute led
> but for by This patch corrects the coefficient mask value introduced
> in commit e518230, which was intended to enable the mute LED
> functionality. During testing, multiple values were evaluated, and an
> incorrect value was mistakenly included in the final commit. This
> update fixes that error by applying the correct mask value for proper
> mute LED behavior.
> 
> Tested on 6.15.5-arch1-1
> 
> Signed-off-by: M SHARAN KUMAR <sharweshraajan@gmail.com>

The patch is still not applicable cleanly.
Please try to fix the mailer setup and resubmit.  At best, test to
send a patch to yourself, and try to apply the patch by yourself,
before resubmitting.

Also, don't forget to add the proper Fixes tag pointing to the
commit.  It must be with 12 chars SHA1 ID followed by the commit
summary.  See Documentation/process/submitting-patches.rst for
details.


thanks,

Takashi

> 
> ---
>  sound/pci/hda/patch_realtek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 060db37eab83..062d439e753d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4753,7 +4753,7 @@ static void
> alc245_fixup_hp_mute_led_v1_coefbit(struct hda_codec *codec,
>   if (action == HDA_FIXUP_ACT_PRE_PROBE) {
>   spec->mute_led_polarity = 0;
>   spec->mute_led_coef.idx = 0x0b;
> - spec->mute_led_coef.mask = 1 << 3;
> + spec->mute_led_coef.mask = 3 << 2;
>   spec->mute_led_coef.on = 1 << 3;
>   spec->mute_led_coef.off = 0;
>   snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);
> -- 
> 2.50.1

Re: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP OMEN 16 Laptop xd000xx

[Takashi Iwai]

On Thu, 17 Jul 2025 11:53:25 +0200,
Takashi Iwai wrote:
> 
> On Thu, 17 Jul 2025 05:02:19 +0200,
> Sharan Kumar Muthu Saravanan wrote:
> > 
> > this patch is to fix my previous Commit e518230 i have fixed mute led
> > but for by This patch corrects the coefficient mask value introduced
> > in commit e518230, which was intended to enable the mute LED
> > functionality. During testing, multiple values were evaluated, and an
> > incorrect value was mistakenly included in the final commit. This
> > update fixes that error by applying the correct mask value for proper
> > mute LED behavior.
> > 
> > Tested on 6.15.5-arch1-1
> > 
> > Signed-off-by: M SHARAN KUMAR <sharweshraajan@gmail.com>
> 
> The patch is still not applicable cleanly.
> Please try to fix the mailer setup and resubmit.  At best, test to
> send a patch to yourself, and try to apply the patch by yourself,
> before resubmitting.
> 
> Also, don't forget to add the proper Fixes tag pointing to the
> commit.  It must be with 12 chars SHA1 ID followed by the commit
> summary.  See Documentation/process/submitting-patches.rst for
> details.

Last but not least: please use the proper subject line.
The subject of this patch is *exactly* same as the commit you're
trying to fix.  This patch isn't about enabling the mute LED; it's
correcting the bug introduced by the previous patch.


Takashi