From: Takashi Iwai <tiwai@suse.de>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: tiwai@suse.com, broonie@kernel.org, perex@perex.cz,
amadeuszx.slawinski@linux.intel.com, linux-sound@vger.kernel.org
Subject: Re: [PATCH v3] ALSA: hda: Transfer firmware in two chunks
Date: Tue, 14 Jan 2025 14:15:56 +0100 [thread overview]
Message-ID: <87ed15zgc3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250114125813.11567-1-cezary.rojewski@intel.com>
On Tue, 14 Jan 2025 13:58:13 +0100,
Cezary Rojewski wrote:
> --- a/include/sound/hdaudio.h
> +++ b/include/sound/hdaudio.h
> @@ -577,6 +577,8 @@ struct hdac_stream *snd_hdac_get_stream(struct hdac_bus *bus,
>
> int snd_hdac_stream_setup(struct hdac_stream *azx_dev, bool code_loading);
> void snd_hdac_stream_cleanup(struct hdac_stream *azx_dev);
> +int snd_hdac_stream_setup_bdle(struct hdac_stream *azx_dev, struct snd_dma_buffer *dmab,
> + struct snd_pcm_runtime *runtime);
Will you use this function by other driver in future?
Otherwise it makes little sense to export this function.
thanks,
Takashi
next prev parent reply other threads:[~2025-01-14 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 12:58 [PATCH v3] ALSA: hda: Transfer firmware in two chunks Cezary Rojewski
2025-01-14 13:15 ` Takashi Iwai [this message]
2025-01-14 18:24 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed15zgc3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox