From: Takashi Iwai <tiwai@suse.de>
To: Kun Hu <huk23@m.fudan.edu.cn>
Cc: Takashi Iwai <tiwai@suse.de>, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: seq: oss: Send fragmented SysEx messages immediately
Date: Mon, 06 Jan 2025 09:09:16 +0100 [thread overview]
Message-ID: <87ed1gxt1v.wl-tiwai@suse.de> (raw)
In-Reply-To: <58DD9B80-CDE3-40B0-96D0-0BDA1F5D841B@m.fudan.edu.cn>
On Mon, 06 Jan 2025 04:10:01 +0100,
Kun Hu wrote:
>
> >>
> >
> >
> > Hi Takashi Iwai,
> > I noticed that in your previous modifications, you seemed to have made lots of changes to the related structures, along with many updates to the snd_seq_oss_synth_sysex function. However, in the latest kernel tree, it seems that only a mutex lock has been added to this function.
> > While this certainly resolves the issue, I’m personally curious to understand the reasoning behind this approach. Was there a specific consideration or constraint that led to this simplified solution?
> >
> > ――
> > Thankx
> > Kun hu
> >
>
> I see, you’re going to submit the patch to 6.14, but a temporary band-aid for 6.13.
Yes. Although the second patch is cleaner, it is more intrusive and
change the behavior, hence it needs more test coverage, which isn't
suitable for 6.13 at this late stage.
Takashi
prev parent reply other threads:[~2025-01-06 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-31 11:55 [PATCH] ALSA: seq: oss: Send fragmented SysEx messages immediately Takashi Iwai
2025-01-06 2:55 ` Kun Hu
2025-01-06 3:10 ` Kun Hu
2025-01-06 8:09 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ed1gxt1v.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=huk23@m.fudan.edu.cn \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox