public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Juan Pablo Fuentealba <jpfuentealbabizama@gmail.com>
Cc: linux-sound@vger.kernel.org, tiwai@suse.de
Subject: Re: [PATCH] ALSA: usb-audio: Add quirk for SmartlinkTechnology M01
Date: Wed, 15 Apr 2026 16:04:57 +0200	[thread overview]
Message-ID: <87fr4wfhfa.wl-tiwai@suse.de> (raw)
In-Reply-To: <CALB_=sh1ONfaueYQ_rzMbzz9xXGTSQaA_km8qEiUfhgLLCq2Qw@mail.gmail.com>

On Wed, 15 Apr 2026 15:33:49 +0200,
Juan Pablo Fuentealba wrote:
> 
> From 7a57eecb5a332da652a0bb3c006fb4ce5316fa17 Mon Sep 17 00:00:00 2001
> From: Juan Pablo Fuentealba Bizama <jpfuentealbabizama@gmail.com>
> Date: Wed, 15 Apr 2026 09:16:47 -0400
> Subject: [PATCH] ALSA: usb-audio: Add quirk for SmartlinkTechnology M01

Embedding those headers (except for From:) in the patch looks wrong.
I can trim them, but please check your setup for submission.

> Add quirk entry for SmartlinkTechnology M01 USB microphone
> to enable the standard mixer interface.
> 
> Signed-off-by: Juan Pablo Fuentealba Bizama <jpfuentealbabizama@gmail.com>
> ---
>  sound/usb/quirks-table.h | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> index 803e03d4d77b..9edfafb7d274 100644
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -3772,6 +3772,21 @@ YAMAHA_DEVICE(0x7010, "UB99"),
>                 }
>         }
>  },
> +{
> +       /*
> +        * SmartlinkTechnology M01
> +        * USB audio device that needs standard mixer quirk
> +        */
> +       USB_DEVICE(0x301a, 0x159b),
> +       QUIRK_DRIVER_INFO {
> +               .vendor_name = "SmartlinkTechnology",
> +               .product_name = "M01",
> +               QUIRK_DATA_COMPOSITE {
> +                       QUIRK_DATA_STANDARD_MIXER(QUIRK_ANY_INTERFACE),
> +                       QUIRK_COMPOSITE_END

Any reason for using the composite type here?
You should be able to use QUIRK_DATA_STANDARD_MIXER() for single
entry.


thanks,

Takashi

      reply	other threads:[~2026-04-15 14:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 13:33 [PATCH] ALSA: usb-audio: Add quirk for SmartlinkTechnology M01 Juan Pablo Fuentealba
2026-04-15 14:04 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fr4wfhfa.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=jpfuentealbabizama@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox