From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v2] ALSA: hda: Notify IEC958 Default PCM switch state changes
Date: Thu, 02 Apr 2026 18:08:49 +0200 [thread overview]
Message-ID: <87fr5dibu6.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260402-hda-spdif-share-notify-v2-1-7c6584ecaa21@gmail.com>
On Thu, 02 Apr 2026 16:45:13 +0200,
Cássio Gabriel wrote:
>
> --- a/sound/hda/common/hda_local.h
> +++ b/sound/hda/common/hda_local.h
> @@ -12,6 +12,8 @@
>
> #include <sound/pcm_drm_eld.h>
>
> +struct snd_kcontrol;
No need for an extra declaration.
> +
> /* We abuse kcontrol_new.subdev field to pass the NID corresponding to
> * the given new control. If id.subdev has a bit flag HDA_SUBDEV_NID_FLAG,
> * snd_hda_ctl_add() takes the lower-bit subdev value as a valid NID.
> @@ -203,6 +205,7 @@ enum { HDA_DIG_NONE, HDA_DIG_EXCLUSIVE, HDA_DIG_ANALOG_DUP }; /* dig_out_used */
> #define HDA_MAX_OUTS 5
>
> struct hda_multi_out {
> + struct snd_kcontrol *share_spdif_kctl; /* cached shared SPDIF switch */
I'd put at the tail of the struct as it's rather an optional stuff.
thanks,
Takashi
next prev parent reply other threads:[~2026-04-02 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 14:45 [PATCH v2] ALSA: hda: Notify IEC958 Default PCM switch state changes Cássio Gabriel
2026-04-02 16:08 ` Takashi Iwai [this message]
2026-04-02 23:53 ` Cássio Gabriel Monteiro Pires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fr5dibu6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox