From: Takashi Iwai <tiwai@suse.de>
To: Haotian Zhang <vulab@iscas.ac.cn>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Philipp Stanner <phasta@kernel.org>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: au88x0: Fix incorrect error handling for PCI config reads
Date: Mon, 17 Nov 2025 17:24:36 +0100 [thread overview]
Message-ID: <87fracfwzf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20251117065559.1138-1-vulab@iscas.ac.cn>
On Mon, 17 Nov 2025 07:55:59 +0100,
Haotian Zhang wrote:
>
> __snd_vortex_probe() uses pci_read_config_word() that returns PCIBIOS_*
> codes (positive values on error). However, the function checks 'err < 0'
> which can never be true for PCIBIOS_* codes, causing errors to be silently
> ignored.
>
> Check for non-zero return value and convert PCIBIOS_* codes using
> pcibios_err_to_errno() into normal errno before returning them.
>
> Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2025-11-17 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 6:55 [PATCH] ALSA: au88x0: Fix incorrect error handling for PCI config reads Haotian Zhang
2025-11-17 7:04 ` Philipp Stanner
2025-11-17 16:24 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fracfwzf.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=phasta@kernel.org \
--cc=tiwai@suse.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox