From: Takashi Iwai <tiwai@suse.de>
To: WangYuli <wangyuli@uniontech.com>
Cc: broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
shuah@kernel.org, linux-sound@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
niecheng1@uniontech.com, guanwentao@uniontech.com,
Jun Zhan <zhanjun@uniontech.com>
Subject: Re: [PATCH] selftests: ALSA: fix memory leak in utimer test
Date: Thu, 31 Jul 2025 17:02:41 +0200 [thread overview]
Message-ID: <87frecqu7i.wl-tiwai@suse.de> (raw)
In-Reply-To: <DE4D931FCF54F3DB+20250731100222.65748-1-wangyuli@uniontech.com>
On Thu, 31 Jul 2025 12:02:22 +0200,
WangYuli wrote:
>
> Free the malloc'd buffer in TEST_F(timer_f, utimer) to prevent
> memory leak.
>
> Reported-by: Jun Zhan <zhanjun@uniontech.com>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
Thanks, applied now. I added Fixes tag in my side.
Takashi
> ---
> tools/testing/selftests/alsa/utimer-test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/alsa/utimer-test.c b/tools/testing/selftests/alsa/utimer-test.c
> index 32ee3ce57721..37964f311a33 100644
> --- a/tools/testing/selftests/alsa/utimer-test.c
> +++ b/tools/testing/selftests/alsa/utimer-test.c
> @@ -135,6 +135,7 @@ TEST_F(timer_f, utimer) {
> pthread_join(ticking_thread, NULL);
> ASSERT_EQ(total_ticks, TICKS_COUNT);
> pclose(rfp);
> + free(buf);
> }
>
> TEST(wrong_timers_test) {
> --
> 2.50.1
>
prev parent reply other threads:[~2025-07-31 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 10:02 [PATCH] selftests: ALSA: fix memory leak in utimer test WangYuli
2025-07-31 15:02 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frecqu7i.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=guanwentao@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niecheng1@uniontech.com \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).