From: Takashi Iwai <tiwai@suse.de>
To: Hendrik Borghorst <hendrikborghorst@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kailang Yang <kailang@realtek.com>,
Stefan Binding <sbinding@opensource.cirrus.com>,
Simon Trimmer <simont@opensource.cirrus.com>,
Athaariq Ardhiansyah <foss@athaariq.my.id>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alsa: support HP Pavilion Aero 13-bg0xxx Mute LED
Date: Sun, 25 Aug 2024 09:46:02 +0200 [thread overview]
Message-ID: <87frqtjb9h.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240824183445.6610-1-hendrikborghorst@gmail.com>
On Sat, 24 Aug 2024 20:34:38 +0200,
Hendrik Borghorst wrote:
>
> This patch adds the HP Pavilion Aero 13 (13-bg0xxx) (year 2024) to list of
> quirks for keyboard LED mute indication.
>
> The laptop has two LEDs (one for speaker and one for mic mute). The
> pre-existing quirk ALC245_FIXUP_HP_X360_MUTE_LEDS chains both the quirk for
> mic and speaker mute.
>
> Tested on 6.11.0-rc4 with the aforementioned laptop.
>
> Signed-off-by: Hendrik Borghorst <hendrikborghorst@gmail.com>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index d022a25635f9..a45062c9ed6d 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10217,6 +10217,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8902, "HP OMEN 16", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x890e, "HP 255 G8 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x8919, "HP Pavilion Aero Laptop 13-be0xxx", ALC287_FIXUP_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8cbd, "HP Pavilion Aero Laptop 13-bg0xxx", ALC245_FIXUP_HP_X360_MUTE_LEDS),
> SND_PCI_QUIRK(0x103c, 0x896d, "HP ZBook Firefly 16 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x896e, "HP EliteBook x360 830 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x8971, "HP EliteBook 830 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
The table is sorted in PCI SSID number. Could you try to put the
entry at the right position?
thanks,
Takashi
next prev parent reply other threads:[~2024-08-25 7:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-24 18:34 [PATCH] alsa: support HP Pavilion Aero 13-bg0xxx Mute LED Hendrik Borghorst
2024-08-25 7:46 ` Takashi Iwai [this message]
2024-08-25 17:43 ` [PATCH v2] " Hendrik Borghorst
2024-08-26 8:31 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frqtjb9h.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=foss@athaariq.my.id \
--cc=hendrikborghorst@gmail.com \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=sbinding@opensource.cirrus.com \
--cc=simont@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox