Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: HyeongJun An <sammiee5311@gmail.com>
Cc: "Takashi Iwai" <tiwai@suse.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Cássio Gabriel" <cassiogabrielcontato@gmail.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: Report a change when only the channel status bytes move
Date: Tue, 08 Sep 2026 16:25:03 +0200	[thread overview]
Message-ID: <87h5jzq0qo.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260908134153.1614273-1-sammiee5311@gmail.com>

On Tue, 08 Sep 2026 15:41:53 +0200,
HyeongJun An wrote:
> 
> The put() callback of "IEC958 Playback Default" returns whether the
> converted register value moved. The convert_from_spdif_status() helper
> reads part of the first two channel status bytes and none of the last
> two, while the get() callback returns all four. So a write that lands
> only in the bits it does not read changes what userspace reads back and
> reports no change. Of the 31 bits above the mode bit, 20 are such bits
> in consumer mode and 29 in professional mode. The core notifies only on
> a positive return.
> 
> Toggling status[2] bit 0 on an HDA HDMI codec moves the read-back from
> 04 00 00 00 to 04 00 01 00 with no event. Toggling the non-audio bit
> in status[0] gives one.
> 
> Compare the stored status as well, the way the ac97 code does. The
> write to the codec stays gated on the converted value.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: HyeongJun An <sammiee5311@gmail.com>
> Assisted-by: Claude:claude-opus-5

Applied now.  Thanks.


Takashi

      reply	other threads:[~2026-09-08 14:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 13:41 [PATCH] ALSA: hda: Report a change when only the channel status bytes move HyeongJun An
2026-09-08 14:25 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h5jzq0qo.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=cassiogabrielcontato@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sammiee5311@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox