public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Harin Lee <me@harin.net>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] ALSA: ctxfi: Clean up DAIO resource allocation
Date: Wed, 01 Apr 2026 14:44:39 +0200	[thread overview]
Message-ID: <87h5purgso.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260401090159.2404387-1-me@harin.net>

On Wed, 01 Apr 2026 11:01:56 +0200,
Harin Lee wrote:
> 
> Clean up the resource allocation in atc_get_resources() and related
> functions, on top of the recent SPDIFI1 fixes.
> 
> The earlier refactoring introduced a kernel crash on hw20k2, where
> daio_device_index() returned -EINVAL for the SPDIFI1 type and the
> value was used as an unsigned array offset. On my development system
> (64G memory), this did not manifest as a crash, making the bug
> difficult to catch during testing.
> 
> Tested on the real hw20k2 hardware with mem=8G to verify the original
> crash and confirm these patches.
> 
> Changes in v2:
>  - Add atc_spdif_in_type() helper to avoid ternary operators in
>    multiple places
>  - Rewrite the SPDIFI type skip condition as explicit model checks
> 
> Harin Lee (3):
>   ALSA: ctxfi: Rename SPDIFI1 to SPDIFI_BAY
>   ALSA: ctxfi: Use correct DAIO type for da_desc
>   ALSA: ctxfi: Precompute SRC allocation loop bound

Applied to for-next branch now.  Thanks.


Takashi

      parent reply	other threads:[~2026-04-01 12:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01  9:01 [PATCH v2 0/3] ALSA: ctxfi: Clean up DAIO resource allocation Harin Lee
2026-04-01  9:01 ` [PATCH v2 1/3] ALSA: ctxfi: Rename SPDIFI1 to SPDIFI_BAY Harin Lee
2026-04-01  9:01 ` [PATCH v2 2/3] ALSA: ctxfi: Use correct DAIO type for da_desc Harin Lee
2026-04-01  9:01 ` [PATCH v2 3/3] ALSA: ctxfi: Precompute SRC allocation loop bound Harin Lee
2026-04-01 12:44 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h5purgso.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=me@harin.net \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox