From: Takashi Iwai <tiwai@suse.de>
To: Philip Willoughby <willerz@gmail.com>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH 1/1 ] Support POD HD PRO
Date: Fri, 27 Mar 2026 13:19:03 +0100 [thread overview]
Message-ID: <87h5q1qxc8.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAKSkzpui0HAx3LSvxOJFi7opb0sR-3oy5Oxw7uYjMep5ZHVJJw@mail.gmail.com>
On Thu, 19 Mar 2026 12:03:08 +0100,
Philip Willoughby wrote:
>
> I apologize for the previous badly-formatted patch.
>
> The POD HD PRO is a POD 500 in a different box.
>
> The USB PID changes but everything else is the same.
>
> Phil Willoughby (1):
> Add Line6 POD HD PRO support
>
> sound/usb/line6/podhd.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
>
> base-commit: b3c48fa1fb397b490101785ddd87caf2e5513a66
> --
> 2.53.0
>
> From 6f3211504f7091fb5ecab36daea4628b3fa4f0db Mon Sep 17 00:00:00 2001
> From: Phil Willoughby <willerz@gmail.com>
> Date: Thu, 19 Mar 2026 10:54:40 +0000
> Subject: [PATCH 1/1] Add Line6 POD HD PRO support
>
> ---
Hmm, the patch misses the description completely and even no sign-off
is given.
> sound/usb/line6/podhd.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/sound/usb/line6/podhd.c b/sound/usb/line6/podhd.c
> index ea1324c22f46..f32712286642 100644
> --- a/sound/usb/line6/podhd.c
> +++ b/sound/usb/line6/podhd.c
> @@ -28,6 +28,7 @@ enum {
> LINE6_PODHD500X,
> LINE6_PODHDDESKTOP,
> LINE6_PODHDPROX,
> + LINE6_PODHDPRO,
... and the patch itself looks malformed, partly due to your mailer.
Please fix it at first, and prepare a properly formatted patch, then
try to submit.
thanks,
Takashi
prev parent reply other threads:[~2026-03-27 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 11:03 [PATCH 1/1 ] Support POD HD PRO Philip Willoughby
2026-03-27 12:19 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5q1qxc8.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-sound@vger.kernel.org \
--cc=willerz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox