public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1 ] Support POD HD PRO
@ 2026-03-19 11:03 Philip Willoughby
  2026-03-27 12:19 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Philip Willoughby @ 2026-03-19 11:03 UTC (permalink / raw)
  To: linux-sound

I apologize for the previous badly-formatted patch.

The POD HD PRO is a POD 500 in a different box.

The USB PID changes but everything else is the same.

Phil Willoughby (1):
 Add Line6 POD HD PRO support

sound/usb/line6/podhd.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)


base-commit: b3c48fa1fb397b490101785ddd87caf2e5513a66
--
2.53.0

From 6f3211504f7091fb5ecab36daea4628b3fa4f0db Mon Sep 17 00:00:00 2001
From: Phil Willoughby <willerz@gmail.com>
Date: Thu, 19 Mar 2026 10:54:40 +0000
Subject: [PATCH 1/1] Add Line6 POD HD PRO support

---
sound/usb/line6/podhd.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/sound/usb/line6/podhd.c b/sound/usb/line6/podhd.c
index ea1324c22f46..f32712286642 100644
--- a/sound/usb/line6/podhd.c
+++ b/sound/usb/line6/podhd.c
@@ -28,6 +28,7 @@ enum {
       LINE6_PODHD500X,
       LINE6_PODHDDESKTOP,
       LINE6_PODHDPROX,
+       LINE6_PODHDPRO,
};

struct usb_line6_podhd {
@@ -442,6 +443,7 @@ static const struct usb_device_id podhd_id_table[] = {
       { LINE6_IF_NUM(0x4159, 0), .driver_info = LINE6_PODHD500X },
       { LINE6_IF_NUM(0x4156, 0), .driver_info = LINE6_PODHDDESKTOP },
       { LINE6_IF_NUM(0x415A, 0), .driver_info = LINE6_PODHDPROX },
+       { LINE6_IF_NUM(0x4157, 0), .driver_info = LINE6_PODHDPRO },
       {}
};

@@ -542,6 +544,19 @@ static const struct line6_properties
podhd_properties_table[] = {
               .ep_audio_r = 0x86,
               .ep_audio_w = 0x02,
       },
+       [LINE6_PODHDPRO] = {
+               .id = "PODHDPRO",
+               .name = "POD HD PRO",
+               .capabilities   = LINE6_CAP_PCM | LINE6_CAP_CONTROL
+                               | LINE6_CAP_HWMON | LINE6_CAP_HWMON_CTL,
+               .altsetting = 1,
+               .ctrl_if = 1,
+               .ep_ctrl_r = 0x81,
+               .ep_ctrl_w = 0x01,
+               .ep_audio_r = 0x86,
+               .ep_audio_w = 0x02,
+       },
+
};

/*
--
2.53.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1 ] Support POD HD PRO
  2026-03-19 11:03 [PATCH 1/1 ] Support POD HD PRO Philip Willoughby
@ 2026-03-27 12:19 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2026-03-27 12:19 UTC (permalink / raw)
  To: Philip Willoughby; +Cc: linux-sound

On Thu, 19 Mar 2026 12:03:08 +0100,
Philip Willoughby wrote:
> 
> I apologize for the previous badly-formatted patch.
> 
> The POD HD PRO is a POD 500 in a different box.
> 
> The USB PID changes but everything else is the same.
> 
> Phil Willoughby (1):
>  Add Line6 POD HD PRO support
> 
> sound/usb/line6/podhd.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> 
> 
> base-commit: b3c48fa1fb397b490101785ddd87caf2e5513a66
> --
> 2.53.0
> 
> From 6f3211504f7091fb5ecab36daea4628b3fa4f0db Mon Sep 17 00:00:00 2001
> From: Phil Willoughby <willerz@gmail.com>
> Date: Thu, 19 Mar 2026 10:54:40 +0000
> Subject: [PATCH 1/1] Add Line6 POD HD PRO support
> 
> ---

Hmm, the patch misses the description completely and even no sign-off
is given.

> sound/usb/line6/podhd.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> 
> diff --git a/sound/usb/line6/podhd.c b/sound/usb/line6/podhd.c
> index ea1324c22f46..f32712286642 100644
> --- a/sound/usb/line6/podhd.c
> +++ b/sound/usb/line6/podhd.c
> @@ -28,6 +28,7 @@ enum {
>        LINE6_PODHD500X,
>        LINE6_PODHDDESKTOP,
>        LINE6_PODHDPROX,
> +       LINE6_PODHDPRO,

... and the patch itself looks malformed, partly due to your mailer.
Please fix it at first, and prepare a properly formatted patch, then
try to submit.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-27 12:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-19 11:03 [PATCH 1/1 ] Support POD HD PRO Philip Willoughby
2026-03-27 12:19 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox