From: Takashi Iwai <tiwai@suse.de>
To: Thomas Nemer <thomas.nemer@fortytwo.fr>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abhinav Mahadevan <abhi220204@gmail.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Fix missing sample-rate control for PreSonus AudioBox USB
Date: Mon, 19 Oct 2026 10:40:37 +0200 [thread overview]
Message-ID: <87ik2yaxru.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261018111519.191844-1-thomas.nemer@fortytwo.fr>
On Sun, 18 Oct 2026 13:15:19 +0200,
Thomas Nemer wrote:
>
> The fixed audio formats for the PreSonus AudioBox USB declare
> .attributes = 0, dropping UAC_EP_CS_ATTR_SAMPLE_RATE that the device
> advertises in its class-specific endpoint descriptors (EP_GENERAL
> bmAttributes 0x01 on both EP 0x01 and EP 0x82).
>
> As a result set_sample_rate_v1() bails out and the kernel never sends
> the UAC1 SET_CUR SAMPLING_FREQ request, leaving the device on its
> power-on default clock. Playback and capture then run distorted
> whenever the stream rate differs from that default. The device keeps
> the last rate set by a host as long as it stays powered, which made the
> regression look intermittent (e.g. it disappears after the device was
> initialized by a host running a kernel without this quirk entry).
>
> Restore the sample-rate attribute on both streams.
>
> Fixes: 34fe4a9df247 ("ALSA: usb-audio: Add quirk for PreSonus AudioBox USB")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thomas Nemer <thomas.nemer@fortytwo.fr>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-10-19 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 11:15 [PATCH] ALSA: usb-audio: Fix missing sample-rate control for PreSonus AudioBox USB Thomas Nemer
2026-10-19 8:40 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik2yaxru.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=abhi220204@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=thomas.nemer@fortytwo.fr \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox