Re: [PATCH v2] ALSA: hda/realtek - ALC236 fix volume mute & mic mute LED on some HP models

[Takashi Iwai <tiwai@suse.de>]

On Mon, 11 Mar 2024 17:29:21 +0100,
fætalize wrote:
> 
> Some HP laptops have received revisions that altered their board IDs
> and therefore the current patches/quirks do not apply to them.
> Specifically, for my Probook 440 G8, I have a board ID of 8a74.
> It is necessary to add a line for that specific model.
> 
> Signed-off-by: Valentine Altair faetalize@pm.me
> ---
> V1 -> V2: No changes.

Now it looks much better.  However,
- Please use the same From matching with your Signed-off-by line.
- The submitted patch itself isn't applicable cleanly.  Likely due to
  your mailer setup that breaks tabs and spaces.  Fix the setup.
  At best, test by yourself before the submission.


thanks,

Takashi

> --- linux-6.8/sound/pci/hda/patch_realtek.c.orig 2024-03-11 11:59:02.989267710 +0000
> +++ linux-6.8/sound/pci/hda/patch_realtek.c 2024-03-11 11:54:16.764227013 +0000
> @@ -9890,6 +9890,7 @@ static const struct snd_pci_quirk alc269
> SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87e5, "HP ProBook 440 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> + SND_PCI_QUIRK(0x103c, 0x8a74, "HP ProBook 440 G8 Notebook PC q", ALC236_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87e7, "HP ProBook 450 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87f1, "HP ProBook 630 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87f2, "HP ProBook 640 G8 Notebook PC", ALC236_FIXUP_HP_GPIO_LED),