From: Takashi Iwai <tiwai@suse.de>
To: "José Miguel Castellanos Valladolid" <josstamy@gmail.com>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable mute LEDs on HP OmniBook X Flip 14-fm0xxx
Date: Sat, 17 Oct 2026 10:28:16 +0200 [thread overview]
Message-ID: <87jyng20kf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261017050615.14481-1-josstamy@gmail.com>
On Sat, 17 Oct 2026 07:06:15 +0200,
José Miguel Castellanos Valladolid wrote:
>
> The HP OmniBook X Flip Laptop 14-fm0xxx (subsystem ID 0x103c8d9f, ALC245
> with two CS35L41 amplifiers over I2C) is currently handled by
> ALC287_FIXUP_CS35L41_I2C_2. That binds the amplifiers but does not set up
> the mute LEDs, so neither the speaker mute key LED nor the microphone mute
> key LED lights up under Linux. With that fixup the codec GPIOs stay
> disabled (IO[0..2] enable=0).
>
> Switch the entry to ALC287_FIXUP_CS35L41_I2C_2_HP_MUTE_LEDS, which chains
> cs35l41_fixup_i2c_two with ALC245_FIXUP_HP_X360_MUTE_LEDS. This keeps the
> amplifier setup and adds the speaker mute LED through the ALC245 COEF
> register and the mic mute LED through codec GPIO2. It is the same fixup
> already used for the 17 Turbine OmniBook 7 DIS (0x103c8d9c).
>
> Tested on the affected laptop with v7.2.11 using the equivalent
> ALC245_FIXUP_HP_ENVY_X360_15_FH0XXX fixup, which has the identical
> cs35l41_fixup_i2c_two + ALC245_FIXUP_HP_X360_MUTE_LEDS chain: hda::mute
> and hda::micmute LED class devices appear and both key LEDs light up
> when muting.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: José Miguel Castellanos Valladolid <josstamy@gmail.com>
Applied now to for-next branch (with Fixes tag of the former quirk).
thanks,
Takashi
prev parent reply other threads:[~2026-10-17 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 5:06 [PATCH] ALSA: hda/realtek: Enable mute LEDs on HP OmniBook X Flip 14-fm0xxx José Miguel Castellanos Valladolid
2026-10-17 8:28 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyng20kf.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=josstamy@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox