From: Takashi Iwai <tiwai@suse.de>
To: Yousef Alhouseen <alhouseenyousef@gmail.com>
Cc: "Geoffrey D . Bennett" <g@b4.vu>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: scarlett2: unwind notify URB init failures
Date: Tue, 30 Jun 2026 14:23:43 +0200 [thread overview]
Message-ID: <87jyrgw71s.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260629160232.29158-1-alhouseenyousef@gmail.com>
On Mon, 29 Jun 2026 18:02:32 +0200,
Yousef Alhouseen wrote:
>
> scarlett2_init_notify() stores the newly allocated URB in mixer->urb
> before allocating the transfer buffer and submitting the URB. If a later
> step fails, the function returns an error while leaving a partially
> initialized notification URB attached to the mixer.
>
> Clean up the URB and transfer buffer locally on those failure paths.
> Leave mixer->urb NULL so later cleanup or retry paths do not see a
> stale notification URB.
Those are released by the common snd_usb_mixer_free() in the error
path of snd_usb_create_mixer(), hence no need to do here.
thanks,
Takashi
next prev parent reply other threads:[~2026-06-30 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 16:02 [PATCH] ALSA: usb-audio: scarlett2: unwind notify URB init failures Yousef Alhouseen
2026-06-30 12:23 ` Takashi Iwai [this message]
2026-06-30 20:37 ` Yousef Alhouseen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyrgw71s.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alhouseenyousef@gmail.com \
--cc=g@b4.vu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox