From: Takashi Iwai <tiwai@suse.de>
To: John Keeping <jkeeping@inmusicbrands.com>
Cc: linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: serial-generic: remove shared static buffer
Date: Mon, 15 Sep 2025 12:34:26 +0200 [thread overview]
Message-ID: <87jz203sy5.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250915094220.2959202-1-jkeeping@inmusicbrands.com>
On Mon, 15 Sep 2025 11:42:19 +0200,
John Keeping wrote:
>
> If multiple instances of this driver are instantiated and try to send
> concurrently then the single static buffer snd_serial_generic_tx_work()
> will cause corruption in the data output.
>
> Move the buffer into the per-instance driver data to avoid this.
>
> Signed-off-by: John Keeping <jkeeping@inmusicbrands.com>
Thanks, applied now to for-next branch.
Takashi
prev parent reply other threads:[~2025-09-15 10:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 9:42 [PATCH] ALSA: serial-generic: remove shared static buffer John Keeping
2025-09-15 10:34 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jz203sy5.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=jkeeping@inmusicbrands.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox