Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	kernel@collabora.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] ALSA: usb-audio: Support jack detection on Sony DualSense PS5
Date: Mon, 02 Jun 2025 16:55:48 +0200	[thread overview]
Message-ID: <87jz5uxkej.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250526-dualsense-alsa-jack-v1-0-1a821463b632@collabora.com>

On Mon, 26 May 2025 16:07:39 +0200,
Cristian Ciocaltea wrote:
> 
> The Sony DualSense PS5 controller has an internal mono speaker, but it
> also provides a 3.5mm jack socket for headphone output and headset
> microphone input.
> 
> Since this is a UAC1 device, it doesn't advertise any jack detection
> capability.  However, the controller is able to report HP & MIC insert
> events via HID, i.e. through a dedicated input device managed by the
> hid-playstation driver [1].
> 
> This patch series implements a quirk to create the jack controls for
> headphone and headset mic, respectively, and registers an input handler
> for each of them in order to intercept the related hotplug events.
> 
> It's worth noting there is no hard dependency on the HID patch set [1],
> as the usb-audio driver will simply bind the jack controls to the input
> devices when they become available - this is managed internally by the
> input handler framework.
> 
> Unrelated to the above, the series also provides fixes to a bunch of
> general coding style issues as reported by checkpatch.
> 
> [1] https://lore.kernel.org/all/20250526-dualsense-hid-jack-v1-0-a65fee4a60cc@collabora.com/
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>

Thanks for patches.  Through a quick glance, the code change looks OK,
but since it's with significant amount of changes, so I'll postpone
after 6.16 merge window (once after I'm back from traveling).


Takashi

  parent reply	other threads:[~2025-06-02 14:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-26 14:07 [PATCH 0/9] ALSA: usb-audio: Support jack detection on Sony DualSense PS5 Cristian Ciocaltea
2025-05-26 14:07 ` [PATCH 1/9] ALSA: usb-audio: Fix code alignment in mixer_quirks Cristian Ciocaltea
2025-05-26 14:07 ` [PATCH 2/9] ALSA: usb-audio: Fix whitespace & blank line issues " Cristian Ciocaltea
2025-05-26 14:07 ` [PATCH 3/9] ALSA: usb-audio: Avoid precedence issues in mixer_quirks macros Cristian Ciocaltea
2025-05-26 14:07 ` [PATCH 4/9] ALSA: usb-audio: Fix block comments in mixer_quirks Cristian Ciocaltea
2025-05-26 14:07 ` [PATCH 5/9] ALSA: usb-audio: Drop unnecessary parentheses " Cristian Ciocaltea
2025-05-26 14:07 ` [PATCH 6/9] ALSA: usb-audio: Avoid multiple assignments " Cristian Ciocaltea
2025-05-26 14:07 ` [PATCH 7/9] ALSA: usb-audio: Simplify NULL comparison " Cristian Ciocaltea
2025-05-26 14:07 ` [PATCH 8/9] ALSA: usb-audio: Remove unneeded wmb() " Cristian Ciocaltea
2025-05-26 14:07 ` [PATCH 9/9] ALSA: usb-audio: Add mixer quirk for Sony DualSense PS5 Cristian Ciocaltea
2025-06-02 14:55 ` Takashi Iwai [this message]
2025-06-02 19:35   ` [PATCH 0/9] ALSA: usb-audio: Support jack detection on " Cristian Ciocaltea
2025-06-09  7:49 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jz5uxkej.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=kernel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox