From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 398A320C00C for ; Fri, 12 Jun 2026 09:08:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781255284; cv=none; b=mAVeXePCPDnHobitD9H0eb7Ve1/4beP2SMzBbbWRWGIlZJcrLmCo+S1SJAoVcch47k3VX4v1Jw+kReIV2dGcNbB4x/ePEMbcnYmsmuLUIBYItXHgaXfL7UCk/zIH3iQ2iG06iuDuWbyIz4ZqnHANrHeqPWvlhwsJwwIMHZoy2xI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781255284; c=relaxed/simple; bh=5/5om7vBN7gvnpaNHOKof4iZJQp6bQP8WkauPx5MAW0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=CaCjfzakYE8IEGbB3xLFM0aXdJ0SNGJLiCzgnQzbey5A2aW6l5CxtZSJGdz4n89dXtMgmKAqslanKuzRTFMNTlq5G4iQsacITbWgjb+xlxbcTSJzetv4EJUwenuJBDn9RYin0JdhwbnXGPpqr3Zfp+VdUsyaBiiP47wRfe/xLVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=fhYKokbO; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=O1/mxa2O; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=kqnu67KY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=lKs/oBXQ; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="fhYKokbO"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="O1/mxa2O"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="kqnu67KY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="lKs/oBXQ" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5CADA6B2B2; Fri, 12 Jun 2026 09:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781255281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUGFRiRBWeS493YYDdMTOwle1hobnx50ihESzbg+z0k=; b=fhYKokbOtfIdsSCOAixSdeBKnyAsE19UhTf6bzXEtF/chBtGtFx4vR9MQU2UK8v7Xga3AD CyqmmZMPu22iJi7wh8JV75pHy3rcbxiAI1PJsLepXV/kSDk+kV40gyF/M2Gyvj5fCqJ2HP mBwOdjy28toasszi4zVlS84YmlEW7kA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781255281; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUGFRiRBWeS493YYDdMTOwle1hobnx50ihESzbg+z0k=; b=O1/mxa2OL6KnzoQPuQ2qthoGTQR/Rr4D923QJYcHP8FYMT1fo8msDNW9yeRoS9SLSVuLke y0OzaXhW2vg57CCA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=kqnu67KY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="lKs/oBXQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1781255280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUGFRiRBWeS493YYDdMTOwle1hobnx50ihESzbg+z0k=; b=kqnu67KYIQCmqeihMrPMXPUDsSM1OX3vnmK/+TiID2spT6BQ6lsSS3JjQjr430u70TL5FQ ABJygIg4/XP5cynIIb06JoxOAkxKfWTvp0HcTc3fcpn+EvDuc4GaV1P3P0D6C1buXdQjEu /6hwTkCWulBl3bBfzLrrgfuDEvg4i+Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1781255280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUGFRiRBWeS493YYDdMTOwle1hobnx50ihESzbg+z0k=; b=lKs/oBXQQ+y0M2WBonGFGHZu+FLEqZCfryC4yBWoGILg3I4f9iWEzk+WPeHe1pheP9KYJj d4yyX3OUD+yte1BA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2925F779A7; Fri, 12 Jun 2026 09:08:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Un2zCHDMK2oWbAAAD6G6ig (envelope-from ); Fri, 12 Jun 2026 09:08:00 +0000 Date: Fri, 12 Jun 2026 11:07:59 +0200 Message-ID: <87mrx0i0sw.wl-tiwai@suse.de> From: Takashi Iwai To: =?ISO-8859-1?Q?C=E1ssio?= Gabriel Cc: Takashi Iwai , Jaroslav Kysela , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, notify@kernel.org Subject: Re: [PATCH] ALSA: pcxhr: Share PLL frequency register calculation In-Reply-To: <20260612-alsa-pcxhr-pll-helper-v1-1-c84ae2bd2e9b@gmail.com> References: <20260612-alsa-pcxhr-pll-helper-v1-1-c84ae2bd2e9b@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Flag: NO X-Rspamd-Action: no action X-Spam-Level: X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_TO(0.00)[gmail.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 5CADA6B2B2 X-Spam-Score: -3.51 On Fri, 12 Jun 2026 05:43:55 +0200, Cássio Gabriel wrote: > > The PCXHR and HR222 clock paths duplicate the PLL divider calculation and > register encoding. The HR222 variant extends the same format with an > additional range for rates above those supported by the older boards. > > Move the complete encoding into pcxhr_pll_freq_register() and pass each > hardware path its existing maximum frequency. The additional encoding > branch is unreachable with the older 110 kHz limit, so this preserves both > paths' accepted ranges and generated register values while removing the > duplicate implementation and its long-standing TODO. > > Signed-off-by: Cássio Gabriel Applied to for-next branch now. Thanks. Takashi