From: Takashi Iwai <tiwai@suse.de>
To: Samuel Dionne-Riel <samuel@dionne-riel.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ALSA: hda/realtek: Add generic quirk for Bass speaker DAC avoidance
Date: Mon, 02 Feb 2026 11:03:27 +0100 [thread overview]
Message-ID: <87ms1r1mz4.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260201231216.1655154-2-samuel@dionne-riel.com>
On Mon, 02 Feb 2026 00:12:14 +0100,
Samuel Dionne-Riel wrote:
>
> This change is for the follow-up commit, where the match on the specific
> device (Minisforum V3 SE) is added.
>
> This pattern (re-routing the bass speakers off of a DAC without volume
> control) seems common enough that having a "model" to match against and
> quickly use to verify may be worthwhile.
>
> The alc285_fixup_thinkpad_x1_gen7 routing was selected, amongst the
> different options, as it should allow tuning the ratio between both
> speaker set.
>
> The routing was verified using `hda-verb`, and picking either 0x00 or
> 0x01. Either routin made the volume of the bass speakers controllable.
>
> hda-verb /dev/snd/hwC1D0 0x17 SET_CONNECT_SEL 0x01
>
> Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
>
> ---
>
> It may be worthwhile to clean-up behind and make the other fixups
> re-routing `0x17` from `0x06` to either `0x02` or `0x03` also use the
> same routing. It's a bit confusing, determining which routing to choose
> when adding one for a device.
>
> - alc289_fixup_asus_ga401
> - alc295_fixup_disable_dac3
>
> Might need to be checked (and re-used within a chain):
>
> - alc287_fixup_yoga9_14iap7_bass_spk_pin
> - alc245_fixup_hp_spectre_x360_eu0xxx
> - alc245_fixup_hp_spectre_x360_16_aa0xxx
>
> I might be missing some, if for example they are handled through pin
> fixups, or other fixup mechanisms.
>
> I don't have the experience needed to know for sure if the cleanup would
> be appropriate. So please excuse the lack of follow-up on that.
>
> Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
Indeed it looks like that we can cleanup a lot regarding this DAC
routing fix-ups. Though, *_thinkpad_x1_gen7() has more workarounds
about the control element renames -- which needs to be verified
whether the very same workaround is applicable to other cases.
IIUC, this kcontrol names (DAC1/DAC2) match with your device
configuration? Could you give alsa-info.sh output?
In anyway, I don't think it's needed to split to two individual
commits. You can fold into one patch.
thanks,
Takashi
next prev parent reply other threads:[~2026-02-02 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 23:12 [PATCH 0/2] ALSA: hda/realtek: Add quirk for Minisforum V3 SE Samuel Dionne-Riel
2026-02-01 23:12 ` [PATCH 1/2] ALSA: hda/realtek: Add generic quirk for Bass speaker DAC avoidance Samuel Dionne-Riel
2026-02-02 10:03 ` Takashi Iwai [this message]
2026-02-01 23:12 ` [PATCH 2/2] ALSA: hda/realtek: Add quirk for Minisforum V3 SE Samuel Dionne-Riel
2026-02-02 10:00 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ms1r1mz4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=samuel@dionne-riel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox