From: Takashi Iwai <tiwai@suse.de>
To: opticXC <aabishmalik3337@gmail.com>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org
Subject: Re: [PATCH 6.6.7 1/1] ALSA: hda/realtek: mute led fix for HP Pavilion 14 ec1xxx series
Date: Fri, 29 Dec 2023 14:24:14 +0100 [thread overview]
Message-ID: <87msttxhtt.wl-tiwai@suse.de> (raw)
In-Reply-To: <20231218203659.32948-2-aabishmalik3337@gmail.com>
On Mon, 18 Dec 2023 21:37:00 +0100,
opticXC wrote:
>
> The HP Pavilion 14 ec1xxx series uses the HP mainboard 8A0F with the ALC287 codec.
> It needs the ALC287_FIXUP_HP_GPIO_LED quirk to enable the mute led.
>
>
> Signed-off-by: opticXC <aabishmalik3337@gmail.com>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index e45d4c405..416cda983 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9881,6 +9881,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> + SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),
The entry has a coding style problem; it uses 4 spaces instead of a
hard tab stop.
Please use a hard tab stop and resubmit.
thanks,
Takashi
next prev parent reply other threads:[~2023-12-29 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 20:37 [PATCH 6.6.7 1/1] ALSA: hda/realtek: mute led fix for HP Pavilion 14 ec1xxx series opticXC
2023-12-29 13:24 ` Takashi Iwai [this message]
2023-12-30 1:16 ` Geraldo Nascimento
2023-12-30 9:04 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msttxhtt.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=aabishmalik3337@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox