Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Cristian Verde <verde.cristian2005@gmail.com>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
	linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add bass speaker quirk for Lenovo Yoga Pro 7 14IRH8
Date: Thu, 10 Sep 2026 20:09:37 +0200	[thread overview]
Message-ID: <87o6e5j7vi.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260910174251.22302-1-verde.cristian2005@gmail.com>

On Thu, 10 Sep 2026 19:42:51 +0200,
Cristian Verde wrote:
> 
> The Lenovo Yoga Pro 7 14IRH8 suffers from missing bass speaker output and
> broken volume scaling (5% volume plays as loud as 100%). The system shares
> the PCI SSID 0x17aa:0x3852 with the older Lenovo Yoga 7 14ITL5, causing the
> ALSA driver to mistakenly match on the PCI subsystem ID and apply
> ALC287_FIXUP_YOGA7_14ITL_SPEAKERS. That quirk only powers on the amplifier
> without routing the 4-speaker DAC pins.
> 
> Add a fixup helper that disambiguates models by checking the HDA codec
> subsystem ID (codec->core.subsystem_id). When the Yoga Pro 7 14IRH8's codec
> SSID (0x17aa:0x38b1) is detected, apply ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN,
> which properly configures pin 0x17 as a speaker output and hooks it to the DAC
> volume controls. Fall back to ALC287_FIXUP_YOGA7_14ITL_SPEAKERS for older
> hardware sharing 0x3852.
> 
> Signed-off-by: Cristian Verde <verde.cristian2005@gmail.com>

This doesn't apply cleanly on the latest code.
Please rebase to sound.git tree for-linus branch (or at least 7.3-rc2)
and resubmit.


thanks,

Takashi

      reply	other threads:[~2026-09-10 18:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 17:42 [PATCH] ALSA: hda/realtek: Add bass speaker quirk for Lenovo Yoga Pro 7 14IRH8 Cristian Verde
2026-09-10 18:09 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6e5j7vi.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=verde.cristian2005@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox