Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Marco Giunta <marco_giunta@outlook.it>
Cc: tiwai@suse.de, broonie@kernel.org, hansg@kernel.org,
	ilpo.jarvinen@linux.intel.com, imitoy@imitoy.top,
	lenb@kernel.org, lgirdwood@gmail.com, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	munzirtaha@gmail.com, nadim@symbolic.software, perex@perex.cz,
	platform-driver-x86@vger.kernel.org, rafael@kernel.org,
	tiwai@suse.com, wangweidong.a@awinic.com, yakov.till@gmail.com
Subject: Re: [PATCH 0/8] ALSA: hda: Add AW88399 HDA side codec driver for Lenovo Legion
Date: Thu, 23 Jul 2026 14:53:16 +0200	[thread overview]
Message-ID: <87o6fxeukj.wl-tiwai@suse.de> (raw)
In-Reply-To: <DS7PR19MB7724E1F838E331DDE7A99E5CFCC02@DS7PR19MB7724.namprd19.prod.outlook.com>

On Thu, 23 Jul 2026 14:37:09 +0200,
Marco Giunta wrote:
> 
> Hi Takashi,
> 
> Thanks for your useful feedback.
> 
> > Through a quick glance, the code changes look mostly OK.
> > But I believe the potential memory leak Sashiko suggested in the patch
> > 7 is a real issue, and it should be fixed.
> 
> I agree with this point. I will prepare a v2 and send it in a few days.
> 
> > In anyway, as this series spans over different areas, we'd need proper
> > ACK's from ASoC, ACPI and platform people in order to get those merged
> > to the upstream.
> 
> Since Mark has already applied patches 1-5 (ASoC library changes)
> to broonie/sound for-7.3, should I rebase the remaining 3 patches
> (ACPI/platform, HDA driver, realtek fixups) on his tree and send
> a v2 just for those? Or would you prefer I do something different?

Please just resubmit for the remaining parts with the given Acks.

Mark, could you send a pull request including your merged stuff, so
that I can apply on the top?


thanks,

Takashi

  reply	other threads:[~2026-07-23 12:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 13:25 [PATCH 0/8] ALSA: hda: Add AW88399 HDA side codec driver for Lenovo Legion Marco Giunta
2026-07-17 13:25 ` [PATCH 1/8] ASoC: aw88399: extract shared device library Marco Giunta
2026-07-21 15:21   ` Ilpo Järvinen
2026-07-21 16:57     ` Mark Brown
2026-07-23  8:45     ` Marco Giunta
2026-07-17 13:25 ` [PATCH 2/8] ASoC: aw88399: derive channel from I2C address on ACPI systems Marco Giunta
2026-07-17 13:25 ` [PATCH 3/8] ASoC: aw88399: add per-instance BSTS status bypass flag Marco Giunta
2026-07-17 13:25 ` [PATCH 4/8] ASoC: aw88399: add firmware reload flag for resume Marco Giunta
2026-07-17 13:25 ` [PATCH 5/8] ASoC: aw88399: add channel setter for HDA side codec Marco Giunta
2026-07-17 13:25 ` [PATCH 6/8] ACPI/platform: add AWDZ8399 to serial-multi-instantiate Marco Giunta
2026-07-21 12:13   ` Rafael J. Wysocki (Intel)
2026-07-21 15:22   ` Ilpo Järvinen
2026-07-17 13:25 ` [PATCH 7/8] ALSA: hda/scodec: add AW88399 HDA side codec driver Marco Giunta
2026-07-17 13:25 ` [PATCH 8/8] ALSA: hda/realtek: enable AW88399 on Lenovo Legion Pro Marco Giunta
2026-07-21 11:32 ` [PATCH 0/8] ALSA: hda: Add AW88399 HDA side codec driver for Lenovo Legion Takashi Iwai
2026-07-23 12:37   ` Marco Giunta
2026-07-23 12:53     ` Takashi Iwai [this message]
2026-07-21 18:19 ` (subset) " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6fxeukj.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=broonie@kernel.org \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=imitoy@imitoy.top \
    --cc=lenb@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=marco_giunta@outlook.it \
    --cc=munzirtaha@gmail.com \
    --cc=nadim@symbolic.software \
    --cc=perex@perex.cz \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=tiwai@suse.com \
    --cc=wangweidong.a@awinic.com \
    --cc=yakov.till@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox