Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Cryolitia PukNgae <cryolitia@uniontech.com>
Cc: 胡连勤 <hulianqin@vivo.com>, "perex@perex.cz" <perex@perex.cz>,
	"tiwai@suse.com" <tiwai@suse.com>, "pav@iki.fi" <pav@iki.fi>,
	"jussi@sonarnerd.net" <jussi@sonarnerd.net>,
	"roy.vegard.ovesen@gmail.com" <roy.vegard.ovesen@gmail.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: usb-audio: Add delay quirk for MOONDROP Moonriver2 Ti
Date: Fri, 16 Jan 2026 15:16:25 +0100	[thread overview]
Message-ID: <87o6mtd4na.wl-tiwai@suse.de> (raw)
In-Reply-To: <75B330C7B5DC3241+2e4c56a1-e16e-4e1d-a491-1f5f4bdd2587@uniontech.com>

On Fri, 16 Jan 2026 07:36:42 +0100,
Cryolitia PukNgae wrote:
> 
> 
> 
> On 1/16/26 14:33, 胡连勤 wrote:
> > Audio control requests that sets sampling frequency sometimes fail on
> > this card. Adding delay between control messages eliminates that problem.
> > 
> > usb 1-1: New USB device found, idVendor=2fc6, idProduct=f06b
> > usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> > usb 1-1: Product: MOONDROP Moonriver2 Ti
> > usb 1-1: Manufacturer: MOONDROP
> > usb 1-1: SerialNumber: MOONDROP Moonriver2 Ti
> > 
> > Signed-off-by: Lianqin Hu <hulianqin@vivo.com>
> > ---
> > 
> > Changes in v2:
> >  - Reordered by PID
> >  - Link to v1: https://lore.kernel.org/all/TYUPR06MB6217CD0C82B11AD3E659D174D28DA@TYUPR06MB6217.apcprd06.prod.outlook.com/
> > 
> >  sound/usb/quirks.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> > index f38330b095e9..2d9f28558874 100644
> > --- a/sound/usb/quirks.c
> > +++ b/sound/usb/quirks.c
> > @@ -2390,6 +2390,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
> >  		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
> >  	DEVICE_FLG(0x2d99, 0x0026, /* HECATE G2 GAMING HEADSET */
> >  		   QUIRK_FLAG_MIXER_PLAYBACK_MIN_MUTE),
> > +	DEVICE_FLG(0x2fc6, 0xf06b, /* MOONDROP Moonriver2 Ti */
> > +		   QUIRK_FLAG_CTL_MSG_DELAY),
> >  	DEVICE_FLG(0x2fc6, 0xf0b7, /* iBasso DC07 Pro */
> >  		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
> >  	DEVICE_FLG(0x30be, 0x0101, /* Schiit Hel */
> 
> LGTM
> 
> Approved-by: Cryolitia PukNgae <cryolitia@uniontech.com>

I guess you meant Reviewed-by?


thanks,

Takashi

  reply	other threads:[~2026-01-16 14:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16  6:33 [PATCH v2] ALSA: usb-audio: Add delay quirk for MOONDROP Moonriver2 Ti 胡连勤
2026-01-16  6:36 ` Cryolitia PukNgae
2026-01-16 14:16   ` Takashi Iwai [this message]
2026-01-19  7:52     ` Cryolitia PukNgae
2026-01-19  8:12 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6mtd4na.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=cryolitia@uniontech.com \
    --cc=hulianqin@vivo.com \
    --cc=jussi@sonarnerd.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=pav@iki.fi \
    --cc=perex@perex.cz \
    --cc=roy.vegard.ovesen@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox